Skip to content
Permalink
Browse files

Change comparison back to NULL

filter_null method previously filtered the NULL values using NULL type in qgis.core which is a QPyNullVariant. 
f9e0093

This was subsequently changed to 'is not None' comparison which is incorrect. The current version fails to filter out the null values.
  • Loading branch information
spatialthoughts committed Jan 4, 2016
1 parent aacb37d commit 899c57a91f2992bcc1298e5bed3776c6e0bd65e1
Showing with 1 addition and 1 deletion.
  1. +1 −1 python/plugins/fTools/tools/doSpatialJoin.py
@@ -56,7 +56,7 @@ def myself(L):

def filter_null(vals):
"""Takes an iterator of values and returns a new iterator returning the same values but skipping any NULL values"""
return (v for v in vals if v is not None)
return (v for v in vals if v != NULL)


class Dialog(QDialog, Ui_Dialog):

0 comments on commit 899c57a

Please sign in to comment.
You can’t perform that action at this time.