Skip to content

Commit 89eb054

Browse files
committed
Fix for PyQgsVectorFileWriter test segfault on Mac
- Initialize newFilename to QString(), or QgsDebugMsg for newFilename segfaults (line 650) - Set test assert to QgsVectorFileWriter::WriterError enum for success (NoError = 0, i.e. false)
1 parent 52e6c50 commit 89eb054

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

tests/src/python/test_qgsvectorfilewriter.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ def testWrite(self):
6767
myLayerOptions = QStringList()
6868
mySelectedOnlyFlag = False
6969
mySkipAttributesFlag = False
70+
myNewFileName = QString()
7071
myGeoCrs = QgsCoordinateReferenceSystem()
7172
myGeoCrs.createFromId(4326, QgsCoordinateReferenceSystem.EpsgCrsId)
7273
myResult = QgsVectorFileWriter.writeAsVectorFormat(
@@ -79,8 +80,9 @@ def testWrite(self):
7980
myErrorMessage,
8081
myOptions,
8182
myLayerOptions,
82-
mySkipAttributesFlag)
83-
assert myResult==True
83+
mySkipAttributesFlag,
84+
myNewFileName)
85+
assert myResult==QgsVectorFileWriter.NoError
8486

8587
if __name__ == '__main__':
8688
unittest.main()

0 commit comments

Comments
 (0)