Maximum 40 entries in config and capabilities cache

qgis · May 11, 2011 · 89fe228 · 89fe228
1 parent a09d043
commit 89fe228
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/mapserver/qgscapabilitiescache.cpp b/src/mapserver/qgscapabilitiescache.cpp
@@ -40,5 +40,11 @@ const QDomDocument* QgsCapabilitiesCache::searchCapabilitiesDocument( const QStr
 
 void QgsCapabilitiesCache::insertCapabilitiesDocument( const QString& configFilePath, const QDomDocument* doc )
 {
+  if( mCachedCapabilities.size() > 40 )
+  {
+    //remove another cache entry to avoid memory problems
+    QHash<QString, QDomDocument>::iterator capIt = mCachedCapabilities.begin();
+    mCachedCapabilities.erase( capIt );
+  }
   mCachedCapabilities.insert( configFilePath, doc->cloneNode().toDocument() );
 }
diff --git a/src/mapserver/qgsconfigcache.cpp b/src/mapserver/qgsconfigcache.cpp
@@ -61,12 +61,9 @@ QgsConfigParser* QgsConfigCache::insertConfiguration( const QString& filePath )
 {
   if ( mCachedConfigurations.size() > 40 )
   {
-    //remove 10 elements to avoid memory problems
+    //remove a cache entry to avoid memory problems
     QHash<QString, QgsConfigParser*>::iterator configIt = mCachedConfigurations.begin();
-    for ( int i = 0; i < 10; ++i )
-    {
-      configIt = mCachedConfigurations.erase( configIt );
-    }
+    mCachedConfigurations.erase( configIt );
   }
 
   //first open file