[afs] Correctly convert attribute values to field type

nyalldawson · nyalldawson · commit 8b0b826df92d · 2018-02-20T13:20:37.000+10:00
Avoids AFS provider returning double values for integer
and long field types
diff --git a/src/providers/arcgisrest/qgsafsshareddata.cpp b/src/providers/arcgisrest/qgsafsshareddata.cpp
@@ -90,7 +90,9 @@ bool QgsAfsSharedData::getFeature( QgsFeatureId id, QgsFeature &f, bool fetchGeo
       QgsAttributes attributes( mFields.size() );
       foreach ( int idx, fetchAttribIdx )
       {
-        attributes[idx] = attributesData[mFields.at( idx ).name()];
+        QVariant attribute = attributesData[mFields.at( idx ).name()];
+        mFields.at( idx ).convertCompatible( attribute );
+        attributes[idx] = attribute;
         if ( mFields.at( idx ).name() == QStringLiteral( "OBJECTID" ) )
         {
           featureId = startId + objectIds.indexOf( attributesData[mFields.at( idx ).name()].toInt() );

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,9 @@ bool QgsAfsSharedData::getFeature( QgsFeatureId id, QgsFeature &f, bool fetchGeo`
`90`	`90`	`QgsAttributes attributes( mFields.size() );`
`91`	`91`	`foreach ( int idx, fetchAttribIdx )`
`92`	`92`	`{`
`93`		`- attributes[idx] = attributesData[mFields.at( idx ).name()];`
	`93`	`+ QVariant attribute = attributesData[mFields.at( idx ).name()];`
	`94`	`+ mFields.at( idx ).convertCompatible( attribute );`
	`95`	`+ attributes[idx] = attribute;`
`94`	`96`	`if ( mFields.at( idx ).name() == QStringLiteral( "OBJECTID" ) )`
`95`	`97`	`{`
`96`	`98`	`featureId = startId + objectIds.indexOf( attributesData[mFields.at( idx ).name()].toInt() );`