Skip to content

Commit 8b70d7f

Browse files
committed
Rename setDeleteCascade/isDeleteCascade in setCascadedDelete/hasCascadedDelete
1 parent 97ad226 commit 8b70d7f

7 files changed

+12
-12
lines changed

python/core/qgsvectorlayerjoininfo.sip

+2-2
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,15 @@ Returns whether values from the joined layer should be cached in memory to speed
132132
.. versionadded:: 3.0
133133
%End
134134

135-
bool isDeleteCascade() const;
135+
bool hasCascadedDelete() const;
136136
%Docstring
137137
Returns whether a feature deleted on the target layer has to impact the
138138
joined layer by deleting the corresponding joined feature.
139139
.. versionadded:: 3.0
140140
:rtype: bool
141141
%End
142142

143-
void setDeleteCascade( bool enabled );
143+
void setCascadedDelete( bool enabled );
144144
%Docstring
145145
Sets whether a feature deleted on the target layer has to impact the
146146
joined layer by deleting the corresponding joined feature.

src/app/qgsjoindialog.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ void QgsJoinDialog::setJoinInfo( const QgsVectorLayerJoinInfo &joinInfo )
7878
mDynamicFormCheckBox->setChecked( joinInfo.isDynamicFormEnabled() );
7979
mEditableJoinLayer->setChecked( joinInfo.isEditable() );
8080
mUpsertOnEditCheckBox->setChecked( joinInfo.hasUpsertOnEdit() );
81-
mDeleteCascadeCheckBox->setChecked( joinInfo.isDeleteCascade() );
81+
mDeleteCascadeCheckBox->setChecked( joinInfo.hasCascadedDelete() );
8282

8383
if ( joinInfo.prefix().isNull() )
8484
{
@@ -123,7 +123,7 @@ QgsVectorLayerJoinInfo QgsJoinDialog::joinInfo() const
123123
if ( info.isEditable() )
124124
{
125125
info.setUpsertOnEdit( mUpsertOnEditCheckBox->isChecked() );
126-
info.setDeleteCascade( mDeleteCascadeCheckBox->isChecked() );
126+
info.setCascadedDelete( mDeleteCascadeCheckBox->isChecked() );
127127
}
128128

129129
if ( mUseCustomPrefix->isChecked() )

src/app/qgsvectorlayerproperties.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1251,7 +1251,7 @@ void QgsVectorLayerProperties::addJoinToTreeWidget( const QgsVectorLayerJoinInfo
12511251
joinItem->setText( 6, QChar( 0x2714 ) );
12521252
}
12531253

1254-
if ( join.isDeleteCascade() )
1254+
if ( join.hasCascadedDelete() )
12551255
{
12561256
joinItem->setText( 7, QChar( 0x2714 ) );
12571257
}

src/core/qgsvectorlayer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -2481,7 +2481,7 @@ bool QgsVectorLayer::deleteFeaturesFromJoinedLayers( QgsFeatureIds fids )
24812481
{
24822482
Q_FOREACH ( const QgsVectorLayerJoinInfo &info, vectorJoins() )
24832483
{
2484-
if ( info.isEditable() && info.isDeleteCascade() )
2484+
if ( info.isEditable() && info.hasCascadedDelete() )
24852485
{
24862486
QgsFeature joinFeature = mJoinBuffer->joinedFeatureOf( &info, getFeature( fid ) );
24872487
if ( joinFeature.isValid() )

src/core/qgsvectorlayerjoinbuffer.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ void QgsVectorLayerJoinBuffer::writeXml( QDomNode &layer_node, QDomDocument &doc
278278
joinElem.setAttribute( QStringLiteral( "dynamicForm" ), joinIt->isDynamicFormEnabled() );
279279
joinElem.setAttribute( QStringLiteral( "editable" ), joinIt->isEditable() );
280280
joinElem.setAttribute( QStringLiteral( "upsertOnEdit" ), joinIt->hasUpsertOnEdit() );
281-
joinElem.setAttribute( QStringLiteral( "deleteCascade" ), joinIt->isDeleteCascade() );
281+
joinElem.setAttribute( QStringLiteral( "cascadedDelete" ), joinIt->hasCascadedDelete() );
282282

283283
if ( joinIt->joinFieldNamesSubset() )
284284
{
@@ -322,7 +322,7 @@ void QgsVectorLayerJoinBuffer::readXml( const QDomNode &layer_node )
322322
info.setDynamicFormEnabled( infoElem.attribute( QStringLiteral( "dynamicForm" ) ).toInt() );
323323
info.setEditable( infoElem.attribute( QStringLiteral( "editable" ) ).toInt() );
324324
info.setUpsertOnEdit( infoElem.attribute( QStringLiteral( "upsertOnEdit" ) ).toInt() );
325-
info.setDeleteCascade( infoElem.attribute( QStringLiteral( "deleteCascade" ) ).toInt() );
325+
info.setCascadedDelete( infoElem.attribute( QStringLiteral( "cascadedDelete" ) ).toInt() );
326326

327327
QDomElement subsetElem = infoElem.firstChildElement( QStringLiteral( "joinFieldsSubset" ) );
328328
if ( !subsetElem.isNull() )

src/core/qgsvectorlayerjoininfo.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ void QgsVectorLayerJoinInfo::setEditable( bool enabled )
4040

4141
if ( ! mEditable )
4242
{
43-
setDeleteCascade( false );
43+
setCascadedDelete( false );
4444
setUpsertOnEdit( false );
4545
}
4646
}

src/core/qgsvectorlayerjoininfo.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,13 @@ class CORE_EXPORT QgsVectorLayerJoinInfo
108108
* joined layer by deleting the corresponding joined feature.
109109
* \since QGIS 3.0
110110
*/
111-
bool isDeleteCascade() const { return mDeleteCascade; }
111+
bool hasCascadedDelete() const { return mCascadedDelete; }
112112

113113
/** Sets whether a feature deleted on the target layer has to impact the
114114
* joined layer by deleting the corresponding joined feature.
115115
* \since QGIS 3.0
116116
*/
117-
void setDeleteCascade( bool enabled ) { mDeleteCascade = enabled; }
117+
void setCascadedDelete( bool enabled ) { mCascadedDelete = enabled; }
118118

119119
/** Returns the prefixed name of the field.
120120
* \param field the field
@@ -182,7 +182,7 @@ class CORE_EXPORT QgsVectorLayerJoinInfo
182182

183183
bool mUpsertOnEdit;
184184

185-
bool mDeleteCascade;
185+
bool mCascadedDelete;
186186

187187
//! Cache for joined attributes to provide fast lookup (size is 0 if no memory caching)
188188
QHash< QString, QgsAttributes> cachedAttributes;

0 commit comments

Comments
 (0)