Skip to content

Commit 8ca5b2a

Browse files
committed
enableAutoGeometryRestore dialog updates
1 parent ea5f3c6 commit 8ca5b2a

5 files changed

+11
-23
lines changed

src/app/qgsbookmarks.cpp

+3-8
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include "qgsmessagelog.h"
2323
#include "qgslogger.h"
2424
#include "qgssettings.h"
25+
#include "qgsgui.h"
2526

2627
#include <QFileDialog>
2728
#include <QFileInfo>
@@ -42,8 +43,9 @@ QgsBookmarks::QgsBookmarks( QWidget *parent )
4243

4344
{
4445
setupUi( this );
46+
QgsGui::enableAutoGeometryRestore( this );
47+
4548
connect( lstBookmarks, &QTreeView::doubleClicked, this, &QgsBookmarks::lstBookmarks_doubleClicked );
46-
restorePosition();
4749

4850
bookmarksDockContents->layout()->setMargin( 0 );
4951
bookmarksDockContents->layout()->setContentsMargins( 0, 0, 0, 0 );
@@ -137,16 +139,9 @@ QgsBookmarks::~QgsBookmarks()
137139
saveWindowLocation();
138140
}
139141

140-
void QgsBookmarks::restorePosition()
141-
{
142-
QgsSettings settings;
143-
restoreGeometry( settings.value( QStringLiteral( "Windows/Bookmarks/geometry" ) ).toByteArray() );
144-
}
145-
146142
void QgsBookmarks::saveWindowLocation()
147143
{
148144
QgsSettings settings;
149-
settings.setValue( QStringLiteral( "Windows/Bookmarks/geometry" ), saveGeometry() );
150145
settings.setValue( QStringLiteral( "Windows/Bookmarks/headerstate" ), lstBookmarks->header()->saveState() );
151146
}
152147

src/app/qgsbookmarks.h

-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ class APP_EXPORT QgsBookmarks : public QgsDockWidget, private Ui::QgsBookmarksBa
164164
QgsBookmarksProxyModel *mProxyModel = nullptr;
165165

166166
void saveWindowLocation();
167-
void restorePosition();
168167

169168
};
170169

src/app/qgscustomization.cpp

+3-5
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#include "qgsapplication.h"
2020
#include "qgslogger.h"
2121
#include "qgsstatusbar.h"
22+
#include "qgsgui.h"
2223

2324
#include <QAction>
2425
#include <QDir>
@@ -47,16 +48,15 @@ QgsCustomizationDialog::QgsCustomizationDialog( QWidget * parent, QSettings * se
4748
{
4849
mSettings = settings;
4950
setupUi( this );
51+
QgsGui::enableAutoGeometryRestore( this );
52+
5053
connect( actionSave, &QAction::triggered, this, &QgsCustomizationDialog::actionSave_triggered );
5154
connect( actionLoad, &QAction::triggered, this, &QgsCustomizationDialog::actionLoad_triggered );
5255
connect( actionExpandAll, &QAction::triggered, this, &QgsCustomizationDialog::actionExpandAll_triggered );
5356
connect( actionCollapseAll, &QAction::triggered, this, &QgsCustomizationDialog::actionCollapseAll_triggered );
5457
connect( actionSelectAll, &QAction::triggered, this, &QgsCustomizationDialog::actionSelectAll_triggered );
5558
connect( mCustomizationEnabledCheckBox, &QCheckBox::toggled, this, &QgsCustomizationDialog::mCustomizationEnabledCheckBox_toggled );
5659

57-
QSettings appSettings;
58-
restoreGeometry( appSettings.value( QStringLiteral( "Windows/Customization/geometry" ) ).toByteArray() );
59-
6060
init();
6161
QStringList myHeaders;
6262
myHeaders << tr( "Object name" ) << tr( "Label" );
@@ -74,8 +74,6 @@ QgsCustomizationDialog::QgsCustomizationDialog( QWidget * parent, QSettings * se
7474

7575
QgsCustomizationDialog::~QgsCustomizationDialog()
7676
{
77-
QSettings settings;
78-
settings.setValue( QStringLiteral( "Windows/Customization/geometry" ), saveGeometry() );
7977
}
8078

8179
QTreeWidgetItem *QgsCustomizationDialog::item( const QString &path, QTreeWidgetItem *widgetItem )

src/app/qgscustomprojectiondialog.cpp

+3-4
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include "qgsprojectionselectiondialog.h"
2727
#include "qgssettings.h"
2828
#include "qgssqliteutils.h"
29+
#include "qgsgui.h"
2930

3031
//qt includes
3132
#include <QFileInfo>
@@ -47,6 +48,8 @@ QgsCustomProjectionDialog::QgsCustomProjectionDialog( QWidget *parent, Qt::Windo
4748
: QDialog( parent, fl )
4849
{
4950
setupUi( this );
51+
QgsGui::enableAutoGeometryRestore( this );
52+
5053
connect( pbnCalculate, &QPushButton::clicked, this, &QgsCustomProjectionDialog::pbnCalculate_clicked );
5154
connect( pbnAdd, &QPushButton::clicked, this, &QgsCustomProjectionDialog::pbnAdd_clicked );
5255
connect( pbnRemove, &QPushButton::clicked, this, &QgsCustomProjectionDialog::pbnRemove_clicked );
@@ -55,8 +58,6 @@ QgsCustomProjectionDialog::QgsCustomProjectionDialog( QWidget *parent, Qt::Windo
5558
connect( buttonBox, &QDialogButtonBox::accepted, this, &QgsCustomProjectionDialog::buttonBox_accepted );
5659
connect( buttonBox, &QDialogButtonBox::helpRequested, this, &QgsCustomProjectionDialog::showHelp );
5760

58-
QgsSettings settings;
59-
restoreGeometry( settings.value( QStringLiteral( "Windows/CustomProjection/geometry" ) ).toByteArray() );
6061

6162
// user database is created at QGIS startup in QgisApp::createDB
6263
// we just check whether there is our database [MD]
@@ -83,8 +84,6 @@ QgsCustomProjectionDialog::QgsCustomProjectionDialog( QWidget *parent, Qt::Windo
8384

8485
QgsCustomProjectionDialog::~QgsCustomProjectionDialog()
8586
{
86-
QgsSettings settings;
87-
settings.setValue( QStringLiteral( "Windows/CustomProjection/geometry" ), saveGeometry() );
8887
}
8988

9089

src/gui/qgsprojectionselectiondialog.cpp

+2-5
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,16 @@
2121
#include "qgsprojectionselectiondialog.h"
2222
#include "qgshelp.h"
2323
#include <QApplication>
24+
#include "qgsgui.h"
2425

2526
QgsProjectionSelectionDialog::QgsProjectionSelectionDialog( QWidget *parent,
2627
Qt::WindowFlags fl )
2728
: QDialog( parent, fl )
2829
{
2930
setupUi( this );
31+
QgsGui::enableAutoGeometryRestore( this );
3032
connect( mButtonBox, &QDialogButtonBox::helpRequested, this, &QgsProjectionSelectionDialog::showHelp );
3133

32-
QgsSettings settings;
33-
restoreGeometry( settings.value( QStringLiteral( "Windows/ProjectionSelector/geometry" ) ).toByteArray() );
34-
3534
//we will show this only when a message is set
3635
textEdit->hide();
3736

@@ -73,8 +72,6 @@ bool QgsProjectionSelectionDialog::showNoProjection() const
7372

7473
QgsProjectionSelectionDialog::~QgsProjectionSelectionDialog()
7574
{
76-
QSettings settings;
77-
settings.setValue( QStringLiteral( "Windows/ProjectionSelector/geometry" ), saveGeometry() );
7875
}
7976

8077
QgsCoordinateReferenceSystem QgsProjectionSelectionDialog::crs() const

0 commit comments

Comments
 (0)