Fix leak in add map tool

qgis · Sep 1, 2015 · 8ce9930 · 8ce9930
1 parent 2904689
commit 8ce9930
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/python/core/geometry/qgsgeometry.sip b/python/core/geometry/qgsgeometry.sip
@@ -47,7 +47,7 @@ class QgsGeometry
      * geom is transferred.
      * @note added in QGIS 2.10
      */
-    QgsGeometry( QgsAbstractGeometryV2* geom /Transfer/ );
+    explicit QgsGeometry( QgsAbstractGeometryV2* geom /Transfer/ );
 
     //! Destructor
     ~QgsGeometry();

diff --git a/src/app/qgsmaptooladdfeature.cpp b/src/app/qgsmaptooladdfeature.cpp
@@ -241,7 +241,7 @@ void QgsMapToolAddFeature::canvasMapReleaseEvent( QgsMapMouseEvent* e )
           poly = new QgsPolygonV2();
         }
         poly->setExteriorRing( curveToAdd );
-        f->setGeometry( poly );
+        f->setGeometry( new QgsGeometry( poly ) );
 
         int avoidIntersectionsReturn = f->geometry()->avoidIntersections();
         if ( avoidIntersectionsReturn == 1 )

diff --git a/src/core/geometry/qgsgeometry.h b/src/core/geometry/qgsgeometry.h
@@ -90,7 +90,7 @@ class CORE_EXPORT QgsGeometry
      * geom is transferred.
      * @note added in QGIS 2.10
      */
-    QgsGeometry( QgsAbstractGeometryV2* geom );
+    explicit QgsGeometry( QgsAbstractGeometryV2* geom );
 
     //! Destructor
     ~QgsGeometry();