Skip to content
Permalink
Browse files

[Geometry checker] Don't recheck any features if fixed error resulted…

… in no changes
  • Loading branch information
manisandro committed Oct 23, 2017
1 parent e089b3b commit 8cefc6561aac427d96d6a48cda491ea36e2e290f
Showing with 2 additions and 15 deletions.
  1. +2 −15 src/analysis/vector/geometry_checker/qgsgeometrychecker.cpp
@@ -113,7 +113,8 @@ bool QgsGeometryChecker::fixError( QgsGeometryCheckError *error, int method, boo
return false;
}

if ( error->resolutionMessage() == tr( "No action" ) )
// If nothing was changed, stop here
if ( changes.isEmpty() )
{
return true;
}
@@ -188,20 +189,6 @@ bool QgsGeometryChecker::fixError( QgsGeometryCheckError *error, int method, boo
}
}

// Remove just-fixed error from newly-found errors if no changes occurred (needed in case error was fixed with "no change")
if ( changes.isEmpty() )
{
for ( QgsGeometryCheckError *recheckErr : recheckErrors )
{
if ( recheckErr->isEqual( error ) )
{
recheckErrors.removeAll( recheckErr );
delete recheckErr;
break;
}
}
}

// Go through error list, update other errors of the checked feature
for ( QgsGeometryCheckError *err : mCheckErrors )
{

0 comments on commit 8cefc65

Please sign in to comment.
You can’t perform that action at this time.