Fix #4088: better handling of unknown geometry types

qgis · Jul 19, 2011 · 8e08c53 · 8e08c53
1 parent 49726d2
commit 8e08c53
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/core/pal/internalexception.h b/src/core/pal/internalexception.h
@@ -81,7 +81,7 @@ namespace pal
       {
           const char* what() const throw()
           {
-            return "Geometry Type is unknow";
+            return "Geometry Type is unknown";
           }
       };
 

diff --git a/src/core/pal/layer.cpp b/src/core/pal/layer.cpp
@@ -262,6 +262,11 @@ namespace pal
 
     // break the (possibly multi-part) geometry into simple geometries
     LinkedList <const GEOSGeometry*> *simpleGeometries = unmulti( the_geom );
+    if ( simpleGeometries == NULL ) // unmulti() failed?
+    {
+      modMutex->unlock();
+      throw InternalException::UnknownGeometry();
+    }
 
     while ( simpleGeometries->size() > 0 )
     {
@@ -277,7 +282,10 @@ namespace pal
       int type = GEOSGeomTypeId( geom );
 
       if ( type != GEOS_POINT && type != GEOS_LINESTRING && type != GEOS_POLYGON )
+      {
+        modMutex->unlock();
         throw InternalException::UnknownGeometry();
+      }
 
       FeaturePart* fpart = new FeaturePart( f, geom );
 

diff --git a/src/core/pal/util.cpp b/src/core/pal/util.cpp
@@ -231,7 +231,8 @@ namespace pal
           final_queue->push_back( geom );
           break;
         default:
-          throw InternalException::UnknownGeometry();
+          delete final_queue;
+          final_queue = NULL;
       }
     }
     delete queue;