-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not differentiate strings from non string in conditions
- Loading branch information
1 parent
b94d17a
commit 8e43aca
Showing
1 changed file
with
2 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e43aca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thinking more about this, we should probably add a reusable function somewhere for creating attribute=value expressions - there's many other parts of the code which create these type of expressions and it'd be good for them to gain the auto-conversion to "is null" expressions too. Maybe something like a static QgsExpression::createFieldEqualsValueExpression( field, value ) function? (Less clumsy naming welcome!)