Skip to content

Commit

Permalink
fix modeller with saga tools
Browse files Browse the repository at this point in the history
  • Loading branch information
Giovanni Manghi committed Oct 31, 2014
1 parent d99d2fd commit 9024bad
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions python/plugins/processing/algs/saga/SagaAlgorithm.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -246,14 +246,14 @@ def processAlgorithm(self, progress):

# Do not export is the output is not a final output
# of the model
if self.model is not None and optim:
for subalg in self.model.algOutputs:
if out.name in subalg:
if subalg[out.name] is not None:
dontExport = False
break
if dontExport:
continue
#if self.model is not None and optim:
# for subalg in self.model.algOutputs:
# if out.name in subalg:
# if subalg[out.name] is not None:
# dontExport = False
# break
# if dontExport:
# continue

if self.cmdname == 'RGB Composite':
if isWindows() or isMac() or not saga208:
Expand Down

3 comments on commit 9024bad

@volaya
Copy link
Contributor

@volaya volaya commented on 9024bad Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue with this? Removing this will cause saga optimizations to not be used

@gioman
Copy link
Contributor

@gioman gioman commented on 9024bad Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all models with SAGA tools give this

Uncaught error while executing algorithm
Traceback (most recent call last):
Traceback (most recent call last):
File "C:/OSGEO41/apps/qgis-dev/./python/plugins\processing\core\GeoAlgorithm.py",
line 212, in execute
self.processAlgorithm(progress)
File "C:/OSGEO41/apps/qgis-dev/./python/plugins\processing\algs\saga\SagaAlgorithm.py",
line 250, in processAlgorithm
for subalg in self.model.algOutputs:
AttributeError: ModelerAlgorithm instance has no attribute 'algOutputs'

@gioman
Copy link
Contributor

@gioman gioman commented on 9024bad Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mine was a last minute try to get at least the modeller working (with saga tools) in qgis 2.6

Please sign in to comment.