Use QRegularExpression and negative look behind

elpaso · elpaso · commit 941d1c0677f1 · 2018-06-19T09:05:03.000+02:00
diff --git a/src/core/qgsmimedatautils.cpp b/src/core/qgsmimedatautils.cpp
@@ -207,12 +207,12 @@ QString QgsMimeDataUtils::encode( const QStringList &items )
 {
   QString encoded;
   // Do not escape colon twice
-  QRegExp re( "([^\\\\]):" );
+  QRegularExpression re( "(?<!\\\\):" );
   Q_FOREACH ( const QString &item, items )
   {
     QString str = item;
     str.replace( '\\', QLatin1String( "\\\\" ) );
-    str.replace( re, QLatin1String( "\\1\\:" ) );
+    str.replace( re, QLatin1String( "\\:" ) );
     encoded += str + ':';
   }
   return encoded.left( encoded.length() - 1 );

Original file line number	Diff line number	Diff line change
`@@ -207,12 +207,12 @@ QString QgsMimeDataUtils::encode( const QStringList &items )`
`207`	`207`	`{`
`208`	`208`	`QString encoded;`
`209`	`209`	`// Do not escape colon twice`
`210`		`- QRegExp re( "([^\\\\]):" );`
	`210`	`+ QRegularExpression re( "(?<!\\\\):" );`
`211`	`211`	`Q_FOREACH ( const QString &item, items )`
`212`	`212`	`{`
`213`	`213`	`QString str = item;`
`214`	`214`	`str.replace( '\\', QLatin1String( "\\\\" ) );`
`215`		`- str.replace( re, QLatin1String( "\\1\\:" ) );`
	`215`	`+ str.replace( re, QLatin1String( "\\:" ) );`
`216`	`216`	`encoded += str + ':';`
`217`	`217`	`}`
`218`	`218`	`return encoded.left( encoded.length() - 1 );`