Skip to content
Permalink
Browse files
remove extra SIP_TRANSFERTHIS in cpp files
  • Loading branch information
3nids committed Apr 25, 2017
1 parent 4b67b27 commit 96151e732aa46e071cf8310dbac7ac8de171df85
Showing with 2 additions and 2 deletions.
  1. +1 −1 src/gui/qgscolorbutton.cpp
  2. +1 −1 src/gui/qgscolorrampbutton.cpp
@@ -38,7 +38,7 @@
#include <QGridLayout>
#include <QPushButton>

QgsColorButton::QgsColorButton( QWidget *parent SIP_TRANSFERTHIS, const QString &cdt, QgsColorSchemeRegistry *registry )
QgsColorButton::QgsColorButton( QWidget *parent, const QString &cdt, QgsColorSchemeRegistry *registry )
: QToolButton( parent )
, mBehavior( QgsColorButton::ShowDialog )
, mColorDialogTitle( cdt.isEmpty() ? tr( "Select Color" ) : cdt )
@@ -36,7 +36,7 @@
#include <QPushButton>
#include <QWidget>

QgsColorRampButton::QgsColorRampButton( QWidget *parent SIP_TRANSFERTHIS, const QString &dialogTitle )
QgsColorRampButton::QgsColorRampButton( QWidget *parent, const QString &dialogTitle )
: QToolButton( parent )
, mColorRampDialogTitle( dialogTitle.isEmpty() ? tr( "Select Color Ramp" ) : dialogTitle )
, mShowGradientOnly( false )

3 comments on commit 96151e7

@nirvn

This comment has been minimized.

Copy link
Contributor

@nirvn nirvn replied Apr 25, 2017

Good cleanup thanks.

While we're at it, those superfluous SIP_TRANSFERTHIS were an attempt to fix build warnings when this tag is used in headers coupled with the use of \param documentation tag. Any idea what happens here? The only way to resolve it is to remove all param tags for a given function.

@3nids

This comment has been minimized.

Copy link
Member Author

@3nids 3nids replied Apr 25, 2017

yep, doxygen config file had no INCLUDE_PATH defined, hence it did not find qgis.h and its SIP macro definitions. This has been fixed in 448d2fd, you can safely use \param in combination of SIP_TRANSFERTHIS

@nirvn

This comment has been minimized.

Copy link
Contributor

@nirvn nirvn replied Apr 25, 2017

Nice

Please sign in to comment.