Skip to content

Commit

Permalink
allow numerical input in rotation map tool
Browse files Browse the repository at this point in the history
* use a combo box to set the angle
* allow snapping to angles (directly enabled when shift + click)
* uses click-click behavior
* rotation anchor is defined on CTRL+click and not on mouse move (TODO: snapping for anchor placement)
  • Loading branch information
3nids committed Apr 28, 2015
1 parent 15c1dbc commit 96560c8
Show file tree
Hide file tree
Showing 2 changed files with 345 additions and 162 deletions.

4 comments on commit 96560c8

@nyalldawson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3nids nice work! One issue I've encountered testing this is that clicking the "x" button in the message bar will crash QGIS. I wonder if a new widget should be created for these types of interactive panels rather than abusing the messagebar? There's many other potential uses for this, including the processing commander, the offset tool spin box, adding spin boxes for the radius select, etc.... It would also leave the messagebar intact for displaying messages during these operations too.

@NathanW2
Copy link
Member

@NathanW2 NathanW2 commented on 96560c8 Apr 28, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3nids
Copy link
Member Author

@3nids 3nids commented on 96560c8 Apr 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback.

I did not like the idea of the status bar (used in the offset tool).
The scene following the mouse is not working on linux and moreover you can't use the mouse (for the snapping).
What would you suggest? A toolbar at the bottom? A dock widget on the left?
I kind of like the idea of the toolbar.

My intention is then to make this coherent with the offset tool.

Thanks

@nyalldawson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3nids I don't like the status bar either. I'd say a new toolbar at the bottom - it could be heavily based off the messagebar, but specifically for use by (non-message) widgets.

Please sign in to comment.