Skip to content
Permalink
Browse files

Make QgsOptionsDialogBase's slots virtual for overriding in derived c…

…lases with non-standard tabs (fixes broken tab behaviour in Plugin manager)
  • Loading branch information
borysiasty committed Nov 6, 2017
1 parent 17aa88c commit 966e2d66395994985fe6dbac6b1efb570c2a36dd
@@ -127,9 +127,10 @@ class QgsOptionsDialogBase : QDialog
%End

protected slots:
void updateOptionsListVerticalTabs();
void optionsStackedWidget_CurrentChanged( int indx );
void optionsStackedWidget_WidgetRemoved( int indx );
virtual void updateOptionsListVerticalTabs();
virtual void optionsStackedWidget_CurrentChanged( int indx );
virtual void optionsStackedWidget_WidgetRemoved( int indx );

void warnAboutMissingObjects();

protected:
@@ -172,7 +172,7 @@ class QgsPluginManager : public QgsOptionsDialogBase, private Ui::QgsPluginManag
void showHelp();

//! Reimplement QgsOptionsDialogBase method to prevent modifying the tab list by signals from the stacked widget
void optionsStackedWidget_CurrentChanged( int indx ) { Q_UNUSED( indx ) }
void optionsStackedWidget_CurrentChanged( int indx ) override { Q_UNUSED( indx ) };

//! Only show plugins from selected repository (e.g. for inspection)
void setRepositoryFilter();
@@ -158,9 +158,10 @@ class GUI_EXPORT QgsOptionsDialogBase : public QDialog
void searchText( const QString &text );

protected slots:
void updateOptionsListVerticalTabs();
void optionsStackedWidget_CurrentChanged( int indx );
void optionsStackedWidget_WidgetRemoved( int indx );
virtual void updateOptionsListVerticalTabs();
virtual void optionsStackedWidget_CurrentChanged( int indx );
virtual void optionsStackedWidget_WidgetRemoved( int indx );

void warnAboutMissingObjects();

protected:

0 comments on commit 966e2d6

Please sign in to comment.
You can’t perform that action at this time.