Skip to content
Permalink
Browse files
Fix Coverity big parameter passed by value warnings
  • Loading branch information
nyalldawson committed Apr 26, 2016
1 parent 5e3645a commit 989ec2c1f836cec128fa170f037ba19d9030610e
@@ -119,7 +119,7 @@ void QgsWCSConnectionItem::deleteConnection()

// ---------------------------------------------------------------------------

QgsWCSLayerItem::QgsWCSLayerItem( QgsDataItem* parent, QString name, QString path, const QgsWcsCapabilitiesProperty& capabilitiesProperty, QgsDataSourceURI dataSourceUri, const QgsWcsCoverageSummary& coverageSummary )
QgsWCSLayerItem::QgsWCSLayerItem( QgsDataItem* parent, QString name, QString path, const QgsWcsCapabilitiesProperty& capabilitiesProperty, const QgsDataSourceURI &dataSourceUri, const QgsWcsCoverageSummary& coverageSummary )
: QgsLayerItem( parent, name, path, QString(), QgsLayerItem::Raster, "wcs" )
, mCapabilities( capabilitiesProperty )
, mDataSourceUri( dataSourceUri )
@@ -49,7 +49,8 @@ class QgsWCSLayerItem : public QgsLayerItem
Q_OBJECT
public:
QgsWCSLayerItem( QgsDataItem* parent, QString name, QString path,
const QgsWcsCapabilitiesProperty& capabilitiesProperty, QgsDataSourceURI dataSourceUri, const QgsWcsCoverageSummary& coverageSummary );
const QgsWcsCapabilitiesProperty& capabilitiesProperty,
const QgsDataSourceURI& dataSourceUri, const QgsWcsCoverageSummary& coverageSummary );
~QgsWCSLayerItem();

QString createUri();
@@ -27,7 +27,7 @@
#include <QEventLoop>


QgsWFSLayerItem::QgsWFSLayerItem( QgsDataItem* parent, QString name, QgsDataSourceURI uri, QString featureType, QString title, QString crsString )
QgsWFSLayerItem::QgsWFSLayerItem( QgsDataItem* parent, QString name, const QgsDataSourceURI& uri, QString featureType, QString title, QString crsString )
: QgsLayerItem( parent, title, parent->path() + '/' + name, QString(), QgsLayerItem::Vector, "WFS" )
{
mUri = QgsWFSDataSourceURI::build( uri.uri(), featureType, crsString );
@@ -67,7 +67,7 @@ class QgsWFSLayerItem : public QgsLayerItem
Q_OBJECT

public:
QgsWFSLayerItem( QgsDataItem* parent, QString name, QgsDataSourceURI uri, QString featureType, QString title, QString crsString );
QgsWFSLayerItem( QgsDataItem* parent, QString name, const QgsDataSourceURI &uri, QString featureType, QString title, QString crsString );
~QgsWFSLayerItem();

};
@@ -215,7 +215,7 @@ void QgsWMSConnectionItem::deleteConnection()

// ---------------------------------------------------------------------------

QgsWMSLayerItem::QgsWMSLayerItem( QgsDataItem* parent, QString name, QString path, const QgsWmsCapabilitiesProperty &capabilitiesProperty, QgsDataSourceURI dataSourceUri, const QgsWmsLayerProperty &layerProperty )
QgsWMSLayerItem::QgsWMSLayerItem( QgsDataItem* parent, QString name, QString path, const QgsWmsCapabilitiesProperty &capabilitiesProperty, const QgsDataSourceURI& dataSourceUri, const QgsWmsLayerProperty &layerProperty )
: QgsLayerItem( parent, name, path, QString(), QgsLayerItem::Raster, "wms" )
, mCapabilitiesProperty( capabilitiesProperty )
, mDataSourceUri( dataSourceUri )
@@ -50,8 +50,8 @@ class QgsWMSLayerItem : public QgsLayerItem
Q_OBJECT
public:
QgsWMSLayerItem( QgsDataItem* parent, QString name, QString path,
const QgsWmsCapabilitiesProperty &capabilitiesProperty,
QgsDataSourceURI dataSourceUri,
const QgsWmsCapabilitiesProperty& capabilitiesProperty,
const QgsDataSourceURI& dataSourceUri,
const QgsWmsLayerProperty &layerProperty );
~QgsWMSLayerItem();

0 comments on commit 989ec2c

Please sign in to comment.