diff --git a/src/core/symbology-ng/qgssymbollayerv2.cpp b/src/core/symbology-ng/qgssymbollayerv2.cpp index aa282ce2d224..0fbcb6fd92a3 100644 --- a/src/core/symbology-ng/qgssymbollayerv2.cpp +++ b/src/core/symbology-ng/qgssymbollayerv2.cpp @@ -47,7 +47,7 @@ QgsExpression* QgsSymbolLayerV2::expression( const QString& property ) QString QgsSymbolLayerV2::dataDefinedPropertyString( const QString& property ) const { const QgsExpression* ex = dataDefinedProperty( property ); - return ex ? ex->dump() : QString(); + return ex ? ex->expression() : QString(); } void QgsSymbolLayerV2::setDataDefinedProperty( const QString& property, const QString& expressionString ) @@ -123,7 +123,7 @@ void QgsSymbolLayerV2::saveDataDefinedProperties( QgsStringMap& stringMap ) cons { if ( ddIt.value() ) { - stringMap.insert( ddIt.key() + "_expression", ddIt.value()->dump() ); + stringMap.insert( ddIt.key() + "_expression", ddIt.value()->expression() ); } } } @@ -141,7 +141,7 @@ void QgsSymbolLayerV2::copyDataDefinedProperties( QgsSymbolLayerV2* destLayer ) { if ( ddIt.value() ) { - destLayer->setDataDefinedProperty( ddIt.key(), ddIt.value()->dump() ); + destLayer->setDataDefinedProperty( ddIt.key(), ddIt.value()->expression() ); } } } diff --git a/src/core/symbology-ng/qgssymbollayerv2utils.cpp b/src/core/symbology-ng/qgssymbollayerv2utils.cpp index 45e679560add..9161dc817551 100644 --- a/src/core/symbology-ng/qgssymbollayerv2utils.cpp +++ b/src/core/symbology-ng/qgssymbollayerv2utils.cpp @@ -2254,7 +2254,7 @@ bool QgsSymbolLayerV2Utils::functionFromSldElement( QDomElement &element, QStrin } else { - function = expr->dump(); + function = expr->expression(); } delete expr; diff --git a/src/gui/symbology-ng/qgsdatadefinedsymboldialog.cpp b/src/gui/symbology-ng/qgsdatadefinedsymboldialog.cpp index 36b2d5cb058e..c4d029194dee 100644 --- a/src/gui/symbology-ng/qgsdatadefinedsymboldialog.cpp +++ b/src/gui/symbology-ng/qgsdatadefinedsymboldialog.cpp @@ -138,7 +138,10 @@ void QgsDataDefinedSymbolDialog::expressionButtonClicked() } else { - attributeCombo->setItemText( 0, QString() ); + if ( comboIndex != 0 ) + { + attributeCombo->setItemText( 0, QString() ); + } attributeCombo->setCurrentIndex( comboIndex ); } }