-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Fixed height now works * Add some GUI elements to access the configuration options
- Loading branch information
Showing
4 changed files
with
66 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn fantastic, the shadow options are great.
Allow me to drop in a last suggestion: allow for data-defined color settings. It's a very important implementation detail that IMO should be in when the feature is released to make sure the symbology isn't a "one trick pony" ;)
With data-defined colors, users will be able to do color highlight of feature(s). Thinking for e.g. of a building layer rendered with the 2.5D symbology, with one or two buildings colored differently to highlight them.
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there are a lot of interesting options left.
One thing: you can convert this to any other renderer and you will have full control. (Still need to promote the variables to layer variables manually though)
So adding it here would be nice, but everything is only a shorthand for features achievable otherwise.
One question for you, @nirvn, do you know what needs to be changed to make classification work after converting it to such a renderer? Some locking, unlocking of symbols? where?
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn , yeah I noticed that switching to single symbol kept the individual layers, and bumped into the @variable issue :) On that point, would it not be better for the 2.5d symbology code to set the variables as layer variables (instead of being created at rendering time)? That way, you could switch back to simple symbol and have it working instantaneously without requiring to manually edit half a dozen data-defined expressions.
If that can be fixed, then I'd be happy to go down that road to highlight individual features / buildings :)
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn teasing you as a transparent way to incite this:

😄
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable issue is on my todo list, no worries. But having more control from inside the configuration interface is definitely nice as well
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use this image for the visual changelog?
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn of course.
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirvn was the image above generated with layer variables or with editing the expression?
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn with layer variables which duplicates the variable set by the 2.5D symbology. IMO the symbology should set variables at the layer level so no editing is needed, as per our discussion.
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some strange ordering z-index issues which I wonder why they happen
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn I can share the full building footprint dataset I'm using here if you want to test things around.
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be nice
9a2f46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.