enable Toggle editing button depending on layer type (fix #4965)

alexbruy · alexbruy · commit a080538aec97 · 2012-02-08T20:55:29.000+02:00
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -6164,9 +6164,10 @@ void QgisApp::activateDeactivateLayerRelatedActions( QgsMapLayer* layer )
       //start editing/stop editing
       if ( dprovider->capabilities() & QgsVectorDataProvider::EditingCapabilities )
       {
-        mActionToggleEditing->setEnabled( !vlayer->isReadOnly() );
+        bool canChangeAttributes = dprovider->capabilities() & QgsVectorDataProvider::ChangeAttributeValues;
+        mActionToggleEditing->setEnabled( canChangeAttributes && !vlayer->isReadOnly() );
         mActionToggleEditing->setChecked( vlayer->isEditable() );
-        mActionSaveEdits->setEnabled( vlayer->isEditable() );
+        mActionSaveEdits->setEnabled( canChangeAttributes && vlayer->isEditable() );
       }
       else
       {

Original file line number	Diff line number	Diff line change
`@@ -6164,9 +6164,10 @@ void QgisApp::activateDeactivateLayerRelatedActions( QgsMapLayer* layer )`
`6164`	`6164`	`//start editing/stop editing`
`6165`	`6165`	`if ( dprovider->capabilities() & QgsVectorDataProvider::EditingCapabilities )`
`6166`	`6166`	`{`
`6167`		`- mActionToggleEditing->setEnabled( !vlayer->isReadOnly() );`
	`6167`	`+ bool canChangeAttributes = dprovider->capabilities() & QgsVectorDataProvider::ChangeAttributeValues;`
	`6168`	`+ mActionToggleEditing->setEnabled( canChangeAttributes && !vlayer->isReadOnly() );`
`6168`	`6169`	`mActionToggleEditing->setChecked( vlayer->isEditable() );`
`6169`		`- mActionSaveEdits->setEnabled( vlayer->isEditable() );`
	`6170`	`+ mActionSaveEdits->setEnabled( canChangeAttributes && vlayer->isEditable() );`
`6170`	`6171`	`}`
`6171`	`6172`	`else`
`6172`	`6173`	`{`