Skip to content
Permalink
Browse files

Kill refreshLegend (not used since a long time)

  • Loading branch information
elpaso committed Oct 8, 2018
1 parent c8577c7 commit a176bad0b0c0db37f1a09bcd4429589e1d7d0bbc
@@ -13424,20 +13424,7 @@ void QgisApp::showLayerProperties( QgsMapLayer *mapLayer )

if ( mapLayer->type() == QgsMapLayer::RasterLayer )
{
#if 0 // See note above about reusing this
QgsRasterLayerProperties *rlp = nullptr;
if ( rlp )
{
rlp->sync();
}
else
{
rlp = new QgsRasterLayerProperties( ml, mMapCanvas, this );
// handled by rendererChanged() connect( rlp, SIGNAL( refreshLegend( QString, bool ) ), mLayerTreeView, SLOT( refreshLayerSymbology( QString ) ) );
}
#else
QgsRasterLayerProperties *rasterLayerPropertiesDialog = new QgsRasterLayerProperties( mapLayer, mMapCanvas, this );
#endif
// Cannot use exec here due to raster transparency map tool:
// in order to pass focus to the canvas, the dialog needs to
// be hidden and shown in non-modal mode.
@@ -13469,20 +13456,7 @@ void QgisApp::showLayerProperties( QgsMapLayer *mapLayer )
{
QgsVectorLayer *vlayer = qobject_cast<QgsVectorLayer *>( mapLayer );

#if 0 // See note above about reusing this
QgsVectorLayerProperties *vlp = nullptr;
if ( vlp )
{
vlp->syncToLayer();
}
else
{
vlp = new QgsVectorLayerProperties( vlayer, this );
// handled by rendererChanged() connect( vlp, SIGNAL( refreshLegend( QString ) ), mLayerTreeView, SLOT( refreshLayerSymbology( QString ) ) );
}
#else
QgsVectorLayerProperties *vectorLayerPropertiesDialog = new QgsVectorLayerProperties( vlayer, this );
#endif
Q_FOREACH ( QgsMapLayerConfigWidgetFactory *factory, mMapLayerPanelFactories )
{
vectorLayerPropertiesDialog->addPropertiesPageFactory( factory );
@@ -1053,12 +1053,6 @@ void QgsRasterLayerProperties::apply()
mRasterLayer->setCustomProperty( "WMSPublishDataSourceUrl", mPublishDataSourceUrlCheckBox->isChecked() );
mRasterLayer->setCustomProperty( "WMSBackgroundLayer", mBackgroundLayerCheckBox->isChecked() );


// update symbology (this is now deprecated and disconnected)
Q_NOWARN_DEPRECATED_PUSH
emit refreshLegend( mRasterLayer->id(), false );
Q_NOWARN_DEPRECATED_POP

// Force a redraw of the legend
mRasterLayer->setLegend( QgsMapLayerLegend::defaultRasterLegend( mRasterLayer ) );

@@ -139,10 +139,6 @@ class APP_EXPORT QgsRasterLayerProperties : public QgsOptionsDialogBase, private

void urlClicked( const QUrl &url );

signals:
//! Emitted when changes to layer were saved to update legend
Q_DECL_DEPRECATED void refreshLegend( const QString &layerID, bool expandItem ) SIP_DEPRECATED;

private:
QPushButton *mBtnStyle = nullptr;
QPushButton *mBtnMetadata = nullptr;
@@ -754,11 +754,6 @@ void QgsVectorLayerProperties::apply()
mLayer->geometryOptions()->setRemoveDuplicateNodes( mRemoveDuplicateNodesCheckbox->isChecked() );
mLayer->geometryOptions()->setGeometryPrecision( mGeometryPrecisionSpinBox->value() );

// update symbology (this is now deprecated and disconnected)
Q_NOWARN_DEPRECATED_PUSH
emit refreshLegend( mLayer->id() );
Q_NOWARN_DEPRECATED_POP

mLayer->triggerRepaint();
// notify the project we've made a change
QgsProject::instance()->setDirty( true );
@@ -132,10 +132,6 @@ class APP_EXPORT QgsVectorLayerProperties : public QgsOptionsDialogBase, private

signals:

//! Emitted when changes to layer were saved to update legend
Q_DECL_DEPRECATED void refreshLegend( const QString &layerID, bool expandItem ) SIP_DEPRECATED;
Q_DECL_DEPRECATED void refreshLegend( const QString &layerID ) SIP_DEPRECATED;

void toggleEditing( QgsMapLayer * );

private slots:

0 comments on commit a176bad

Please sign in to comment.
You can’t perform that action at this time.