Skip to content

Commit a528eb9

Browse files
committed
[auth] Fix return value for plugins that do not support an expansion
Bug not evident until there were providers with multiple credential expansions (now supported in OWS providers). Lack of support for an expansion should only trigger a debug message, not a failure. (cherry-picked from 194b5ad)
1 parent 682023f commit a528eb9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/core/auth/qgsauthmanager.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -1365,8 +1365,8 @@ bool QgsAuthManager::updateNetworkRequest( QNetworkRequest &request, const QStri
13651365
{
13661366
if ( !( authmethod->supportedExpansions() & QgsAuthMethod::NetworkRequest ) )
13671367
{
1368-
QgsDebugMsg( QString( "Data source URI updating not supported by authcfg: %1" ).arg( authcfg ) );
1369-
return false;
1368+
QgsDebugMsg( QString( "Network request updating not supported by authcfg: %1" ).arg( authcfg ) );
1369+
return true;
13701370
}
13711371

13721372
if ( !authmethod->updateNetworkRequest( request, authcfg, dataprovider.toLower() ) )
@@ -1392,7 +1392,7 @@ bool QgsAuthManager::updateNetworkReply( QNetworkReply *reply, const QString& au
13921392
if ( !( authmethod->supportedExpansions() & QgsAuthMethod::NetworkReply ) )
13931393
{
13941394
QgsDebugMsg( QString( "Network reply updating not supported by authcfg: %1" ).arg( authcfg ) );
1395-
return false;
1395+
return true;
13961396
}
13971397

13981398
if ( !authmethod->updateNetworkReply( reply, authcfg, dataprovider.toLower() ) )
@@ -1418,7 +1418,7 @@ bool QgsAuthManager::updateDataSourceUriItems( QStringList &connectionItems, con
14181418
if ( !( authmethod->supportedExpansions() & QgsAuthMethod::DataSourceURI ) )
14191419
{
14201420
QgsDebugMsg( QString( "Data source URI updating not supported by authcfg: %1" ).arg( authcfg ) );
1421-
return false;
1421+
return true;
14221422
}
14231423

14241424
if ( !authmethod->updateDataSourceUriItems( connectionItems, authcfg, dataprovider.toLower() ) )

0 commit comments

Comments
 (0)