You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Hmmm the original commit mainly contained removal of the Q_ASSERT @nyalldawson removed in the meanwhile (was crashing rule-based labeling in normal cases), so after rebase the "main" change in the commit was gone.
I do not remember anymore what was the rationale for this other change... if it breaks DXF export I will revert it then...
a64ea0b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wonder-sk is this commit message correct?
a64ea0b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is called from the dxf export to replace the vector label providers with dxf label providers. I guess this breaks that.
a64ea0b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm the original commit mainly contained removal of the Q_ASSERT @nyalldawson removed in the meanwhile (was crashing rule-based labeling in normal cases), so after rebase the "main" change in the commit was gone.
I do not remember anymore what was the rationale for this other change... if it breaks DXF export I will revert it then...
a64ea0b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted in d69910a. It didn't crash as expected on windows though - unexpectedly Q_ASSERT is a noop in RelWithDebInfo.