Merge pull request #5131 from nyalldawson/location_algs

Rework Select by Location algorithm

Author: nyalldawson

python/core/qgsfeaturesource.sip

@@ -114,6 +114,12 @@ class QgsFeatureSource
  :rtype: QgsRectangle
 %End
 
+    virtual QgsFeatureIds allFeatureIds() const;
+%Docstring
+ Returns a list of all feature IDs for features present in the source.
+ :rtype: QgsFeatureIds
+%End
+
 };
 
 

python/core/qgsvectorlayer.sip

@@ -576,12 +576,6 @@ Select not selected features and deselect selected ones
 Select all the features
 %End
 
-    QgsFeatureIds allFeatureIds() const;
-%Docstring
-Get all feature Ids
- :rtype: QgsFeatureIds
-%End
-
     void invertSelectionInRectangle( QgsRectangle &rect );
 %Docstring
  Invert selection of features found within the search rectangle (in layer's coordinates)

python/plugins/processing/algs/help/qgis.yaml

@@ -189,9 +189,6 @@ qgis:extractbyexpression: >
 
   For more information about expressions see the <a href ="{qgisdocs}/user_manual/working_with_vector/expression.html">user manual</a>
 
-qgis:extractbylocation: >
-  This algorithm creates a new vector layer that only contains matching features from an input layer. The criteria for adding features to the resulting layer is defined based on the spatial relationship between each feature and the features in an additional layer.
-
 qgis:extractnodes: >
   This algorithm takes a line or polygon layer and generates a point layer with points representing the nodes in the input lines or polygons. The attributes associated to each point are the same ones associated to the line or polygon that the point belongs to.
 
@@ -519,10 +516,6 @@ qgis:selectbyexpression: >
 
   For more information about expressions see the <a href ="{qgisdocs}/user_manual/working_with_vector/expression.html">user manual</a>
 
-
-qgis:selectbylocation: >
-  This algorithm creates a selection in a vector layer. The criteria for selecting features is based on the spatial relationship between each feature and the features in an additional layer.
-
 qgis:setmvalue: >
   This algorithm sets the M value for geometries in a layer.
 

python/plugins/processing/algs/qgis/ExtractByLocation.py

@@ -166,8 +166,6 @@
 from .VoronoiPolygons import VoronoiPolygons
 from .ZonalStatistics import ZonalStatistics
 
-# from .ExtractByLocation import ExtractByLocation
-# from .SelectByLocation import SelectByLocation
 # from .SpatialJoin import SpatialJoin
 
 pluginPath = os.path.normpath(os.path.join(
@@ -183,8 +181,6 @@ def __init__(self):
 
     def getAlgs(self):
         # algs = [
-        #         SelectByLocation(),
-        #         ExtractByLocation(),
         #         SpatialJoin(),
         #         ]
         algs = [AddTableField(),

python/plugins/processing/algs/qgis/QGISAlgorithmProvider.py

@@ -2,7 +2,7 @@
 
 """
 ***************************************************************************
-    SelectByLocation.py
+    SetRasterStyle.py
     ---------------------
     Date                 : August 2012
     Copyright            : (C) 2012 by Victor Olaya

python/plugins/processing/algs/qgis/SelectByLocation.py

@@ -2,7 +2,7 @@
 
 """
 ***************************************************************************
-    SelectByLocation.py
+    SetVectorStyle.py
     ---------------------
     Date                 : August 2012
     Copyright            : (C) 2012 by Victor Olaya