Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Ensure canvas has focus if nothing else has
Forward port from Sourcepole's fork
- Loading branch information
1 parent
4c52607
commit a6b0c44
Showing
2 changed files
with
12 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6b0c44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @nyalldawson I have found out this commit breaks shift+drag of 3D view when the dock widget is docked - https://issues.qgis.org/issues/17337 - and I can't really see how to safely fix that while keeping the canvas auto-focus behavior. I am a bit worried that it may cause other similar issues in the future by forcing the focus to canvas. I would prefer to roll back this change to have modifier keys work correctly in 3D view...
a6b0c44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wonder-sk I'm ok for you to revert!
@manisandro you may want to revert from Kadas too
a6b0c44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson Thanks for the heads up, we haven't had any issues with it, and it is pretty essential for our "CAD"-style floating coordinate input widgets.