-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix #10747 - Don't force multi type on point features
Ref #10672 - Commited fix to force multitypes on shapefiles
- Loading branch information
Showing
1 changed file
with
3 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8ce356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that you never know with shapefiles if they are multi or not, hence the idea of forcing multi.
Or do you have another idea how to handle this?
(backport to 2.4?)
a8ce356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So
destIsMulti
is not right with shapefiles?Forcing multi-type break copy and paste for point files so I don't think we should force it here.
a8ce356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, your fix seems perfect to me.
a8ce356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO the default shouold be POINT, not MULTIPOINT, used only in very specialized cases. Multipoints are really a PITA, almost always.
a8ce356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for any other sources than shapefiles, it is based on the layer definition. If layer is single, transformation is to single.
But for shapefiles, the multi-type is undefined, hence we need to force the conversion to multi. This does not cause any trouble since there is no distinction between single- and multi-line/polygon in the format. But, apparently, this is not the case for points. This commit is fixing the case for the points.