[Geometry checker] Fix some feature highlighting issues

qgis · Oct 23, 2017 · aa27b664608f967862e2561f6e28df33acd70879 · aa27b66
1 parent 0740979
commit aa27b664608f967862e2561f6e28df33acd70879
Unified Split

Showing with 5 additions and 2 deletions.

+5 −2 src/plugins/geometry_checker/ui/qgsgeometrycheckerresulttab.cpp
diff --git a/src/plugins/geometry_checker/ui/qgsgeometrycheckerresulttab.cpp b/src/plugins/geometry_checker/ui/qgsgeometrycheckerresulttab.cpp
@@ -72,7 +72,7 @@ QgsGeometryCheckerResultTab::QgsGeometryCheckerResultTab( QgisInterface *iface,
   connect( checker, &QgsGeometryChecker::errorAdded, this, &QgsGeometryCheckerResultTab::addError );
   connect( checker, &QgsGeometryChecker::errorUpdated, this, &QgsGeometryCheckerResultTab::updateError );
   connect( ui.tableWidgetErrors->selectionModel(), &QItemSelectionModel::selectionChanged, this, &QgsGeometryCheckerResultTab::onSelectionChanged );
-  connect( ui.buttonGroupSelectAction, static_cast<void ( QButtonGroup::* )( int )>( &QButtonGroup::buttonClicked ), this, &QgsGeometryCheckerResultTab::highlightErrors );
+  connect( ui.buttonGroupSelectAction, static_cast<void ( QButtonGroup::* )( int )>( &QButtonGroup::buttonClicked ), this, [this]( int ) { QgsGeometryCheckerResultTab::highlightErrors(); } );
   connect( ui.pushButtonOpenAttributeTable, &QAbstractButton::clicked, this, &QgsGeometryCheckerResultTab::openAttributeTable );
   connect( ui.pushButtonFixWithDefault, &QAbstractButton::clicked, this, &QgsGeometryCheckerResultTab::fixErrorsWithDefault );
   connect( ui.pushButtonFixWithPrompt, &QAbstractButton::clicked, this, &QgsGeometryCheckerResultTab::fixErrorsWithPrompt );
@@ -388,7 +388,10 @@ void QgsGeometryCheckerResultTab::highlightErrors( bool current )
     }
   }
 
-  mIface->mapCanvas()->setExtent( totextent );
+  if ( !totextent.isEmpty() )
+  {
+    mIface->mapCanvas()->setExtent( totextent );
+  }
   mIface->mapCanvas()->refresh();
 }