Skip to content

Commit ab17869

Browse files
jef-njef-n
committed
fix missing overrides warnings
1 parent ddecc6f commit ab17869

14 files changed

Lines changed: 67 additions & 67 deletions

‎src/plugins/geometry_checker/checks/qgsgeometryanglecheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ class QgsGeometryAngleCheck : public QgsGeometryCheck
1717
public:
1818
QgsGeometryAngleCheck( QgsFeaturePool* featurePool, double minAngle )
1919
: QgsGeometryCheck( FeatureNodeCheck, featurePool ), mMinAngle( minAngle ) {}
20-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList& messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
21-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
22-
const QStringList& getResolutionMethods() const;
23-
QString errorDescription() const { return tr( "Minimal angle" ); }
24-
QString errorName() const { return "QgsGeometryAngleCheck"; }
20+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList& messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
21+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
22+
const QStringList& getResolutionMethods() const override;
23+
QString errorDescription() const override { return tr( "Minimal angle" ); }
24+
QString errorName() const override { return "QgsGeometryAngleCheck"; }
2525
private:
2626
enum ResolutionMethod { DeleteNode, NoChange };
2727
double mMinAngle;

‎src/plugins/geometry_checker/checks/qgsgeometryareacheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ class QgsGeometryAreaCheck : public QgsGeometryCheck
1919
public:
2020
QgsGeometryAreaCheck( QgsFeaturePool* featurePool, double threshold )
2121
: QgsGeometryCheck( FeatureCheck, featurePool ), mThreshold( threshold ) {}
22-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList& messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
23-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
24-
const QStringList& getResolutionMethods() const;
25-
QString errorDescription() const { return tr( "Minimal area" ); }
26-
QString errorName() const { return "QgsGeometryAreaCheck"; }
22+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList& messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
23+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
24+
const QStringList& getResolutionMethods() const override;
25+
QString errorDescription() const override { return tr( "Minimal area" ); }
26+
QString errorName() const override { return "QgsGeometryAreaCheck"; }
2727
private:
2828
enum ResolutionMethod { MergeLongestEdge, MergeLargestArea, MergeIdenticalAttribute, Delete, NoChange };
2929

‎src/plugins/geometry_checker/checks/qgsgeometrycontainedcheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ class QgsGeometryContainedCheck : public QgsGeometryCheck
4040

4141
public:
4242
QgsGeometryContainedCheck( QgsFeaturePool* featurePool ) : QgsGeometryCheck( FeatureCheck, featurePool ) {}
43-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList& messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
44-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
45-
const QStringList& getResolutionMethods() const;
46-
QString errorDescription() const { return tr( "Within" ); }
47-
QString errorName() const { return "QgsGeometryContainedCheck"; }
43+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList& messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
44+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
45+
const QStringList& getResolutionMethods() const override;
46+
QString errorDescription() const override { return tr( "Within" ); }
47+
QString errorName() const override { return "QgsGeometryContainedCheck"; }
4848
private:
4949
enum ResolutionMethod { Delete, NoChange };
5050
};

‎src/plugins/geometry_checker/checks/qgsgeometrydegeneratepolygoncheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ class QgsGeometryDegeneratePolygonCheck : public QgsGeometryCheck
1717
public:
1818
QgsGeometryDegeneratePolygonCheck( QgsFeaturePool* featurePool )
1919
: QgsGeometryCheck( FeatureNodeCheck, featurePool ) {}
20-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
21-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
22-
const QStringList& getResolutionMethods() const;
23-
QString errorDescription() const { return tr( "Polygon with less than three nodes" ); }
24-
QString errorName() const { return "QgsGeometryDegeneratePolygonCheck"; }
20+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
21+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
22+
const QStringList& getResolutionMethods() const override;
23+
QString errorDescription() const override { return tr( "Polygon with less than three nodes" ); }
24+
QString errorName() const override { return "QgsGeometryDegeneratePolygonCheck"; }
2525

2626
private:
2727
enum ResolutionMethod { DeleteRing, NoChange };

‎src/plugins/geometry_checker/checks/qgsgeometryduplicatecheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ class QgsGeometryDuplicateCheck : public QgsGeometryCheck
4949
public:
5050
QgsGeometryDuplicateCheck( QgsFeaturePool* featurePool )
5151
: QgsGeometryCheck( FeatureCheck, featurePool ) {}
52-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
53-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
54-
const QStringList& getResolutionMethods() const;
55-
QString errorDescription() const { return tr( "Duplicate" ); }
56-
QString errorName() const { return "QgsGeometryDuplicateCheck"; }
52+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
53+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
54+
const QStringList& getResolutionMethods() const override;
55+
QString errorDescription() const override { return tr( "Duplicate" ); }
56+
QString errorName() const override { return "QgsGeometryDuplicateCheck"; }
5757

5858
private:
5959
enum ResolutionMethod { NoChange, RemoveDuplicates };

‎src/plugins/geometry_checker/checks/qgsgeometryduplicatenodescheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ class QgsGeometryDuplicateNodesCheck : public QgsGeometryCheck
1717
public:
1818
QgsGeometryDuplicateNodesCheck( QgsFeaturePool* featurePool )
1919
: QgsGeometryCheck( FeatureNodeCheck, featurePool ) {}
20-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
21-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
22-
const QStringList& getResolutionMethods() const;
23-
QString errorDescription() const { return tr( "Duplicate node" ); }
24-
QString errorName() const { return "QgsGeometryDuplicateNodesCheck"; }
20+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
21+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
22+
const QStringList& getResolutionMethods() const override;
23+
QString errorDescription() const override { return tr( "Duplicate node" ); }
24+
QString errorName() const override { return "QgsGeometryDuplicateNodesCheck"; }
2525

2626
private:
2727
enum ResolutionMethod { RemoveDuplicates, NoChange };

‎src/plugins/geometry_checker/checks/qgsgeometrygapcheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,11 @@ class QgsGeometryGapCheck : public QgsGeometryCheck
7979
public:
8080
QgsGeometryGapCheck( QgsFeaturePool* featurePool, double threshold )
8181
: QgsGeometryCheck( LayerCheck, featurePool ), mThreshold( threshold ) {}
82-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
83-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
84-
const QStringList& getResolutionMethods() const;
85-
QString errorDescription() const { return tr( "Gap" ); }
86-
QString errorName() const { return "QgsGeometryGapCheck"; }
82+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
83+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
84+
const QStringList& getResolutionMethods() const override;
85+
QString errorDescription() const override { return tr( "Gap" ); }
86+
QString errorName() const override { return "QgsGeometryGapCheck"; }
8787

8888
private:
8989
enum ResolutionMethod { MergeLongestEdge, NoChange };

‎src/plugins/geometry_checker/checks/qgsgeometryholecheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ class QgsGeometryHoleCheck : public QgsGeometryCheck
1717
public:
1818
QgsGeometryHoleCheck( QgsFeaturePool* featurePool )
1919
: QgsGeometryCheck( FeatureCheck, featurePool ) {}
20-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
21-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
22-
const QStringList& getResolutionMethods() const;
23-
QString errorDescription() const { return tr( "Polygon with hole" ); }
24-
QString errorName() const { return "QgsGeometryHoleCheck"; }
20+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
21+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
22+
const QStringList& getResolutionMethods() const override;
23+
QString errorDescription() const override { return tr( "Polygon with hole" ); }
24+
QString errorName() const override { return "QgsGeometryHoleCheck"; }
2525
private:
2626
enum ResolutionMethod { RemoveHoles, NoChange };
2727
};

‎src/plugins/geometry_checker/checks/qgsgeometrymultipartcheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ class QgsGeometryMultipartCheck : public QgsGeometryCheck
1717
public:
1818
QgsGeometryMultipartCheck( QgsFeaturePool* featurePool )
1919
: QgsGeometryCheck( FeatureCheck, featurePool ) {}
20-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
21-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
22-
const QStringList& getResolutionMethods() const;
23-
QString errorDescription() const { return tr( "Multipart object with only one feature" ); }
24-
QString errorName() const { return "QgsGeometryMultipartCheck"; }
20+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
21+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
22+
const QStringList& getResolutionMethods() const override;
23+
QString errorDescription() const override { return tr( "Multipart object with only one feature" ); }
24+
QString errorName() const override { return "QgsGeometryMultipartCheck"; }
2525
private:
2626
enum ResolutionMethod { ConvertToSingle, RemoveObject, NoChange };
2727
};

‎src/plugins/geometry_checker/checks/qgsgeometryoverlapcheck.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ class QgsGeometryOverlapCheck : public QgsGeometryCheck
5050
public:
5151
QgsGeometryOverlapCheck( QgsFeaturePool* featurePool, double threshold )
5252
: QgsGeometryCheck( FeatureCheck, featurePool ), mThreshold( threshold ) {}
53-
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const;
54-
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const;
55-
const QStringList& getResolutionMethods() const;
56-
QString errorDescription() const { return tr( "Overlap" ); }
57-
QString errorName() const { return "QgsGeometryOverlapCheck"; }
53+
void collectErrors( QList<QgsGeometryCheckError*>& errors, QStringList &messages, QAtomicInt* progressCounter = 0, const QgsFeatureIds& ids = QgsFeatureIds() ) const override;
54+
void fixError( QgsGeometryCheckError* error, int method, int mergeAttributeIndex, Changes& changes ) const override;
55+
const QStringList& getResolutionMethods() const override;
56+
QString errorDescription() const override { return tr( "Overlap" ); }
57+
QString errorName() const override { return "QgsGeometryOverlapCheck"; }
5858
private:
5959
enum ResolutionMethod { Subtract, NoChange };
6060
double mThreshold;

0 commit comments

Comments
 (0)