Remove messagebox confirmation on geopackage compact

nyalldawson · nyalldawson · commit ab5c4fc8ef45 · 2018-10-12T09:30:59.000+10:00
Now that we use a proxy task, users will have o/s level notifications
if the compact takes a lengthy time
diff --git a/src/providers/ogr/qgsgeopackagedataitems.cpp b/src/providers/ogr/qgsgeopackagedataitems.cpp
@@ -475,11 +475,7 @@ void QgsGeoPackageCollectionItem::vacuumGeoPackageDbAction()
 {
   QString errCause;
   bool result = QgsGeoPackageCollectionItem::vacuumGeoPackageDb( mPath, mName, errCause );
-  if ( result && errCause.isEmpty() )
-  {
-    QMessageBox::information( nullptr, tr( "Database compact (VACUUM)" ), tr( "Database <b>%1</b> has been compacted successfully." ).arg( mName ) );
-  }
-  else
+  if ( !result || !errCause.isEmpty() )
   {
     QMessageBox::warning( nullptr, tr( "Database compact (VACUUM)" ), errCause );
   }

Original file line number	Diff line number	Diff line change
`@@ -475,11 +475,7 @@ void QgsGeoPackageCollectionItem::vacuumGeoPackageDbAction()`
`475`	`475`	`{`
`476`	`476`	`QString errCause;`
`477`	`477`	`bool result = QgsGeoPackageCollectionItem::vacuumGeoPackageDb( mPath, mName, errCause );`
`478`		`- if ( result && errCause.isEmpty() )`
`479`		`- {`
`480`		`- QMessageBox::information( nullptr, tr( "Database compact (VACUUM)" ), tr( "Database <b>%1</b> has been compacted successfully." ).arg( mName ) );`
`481`		`- }`
`482`		`- else`
	`478`	`+ if ( !result \|\| !errCause.isEmpty() )`
`483`	`479`	`{`
`484`	`480`	`QMessageBox::warning( nullptr, tr( "Database compact (VACUUM)" ), errCause );`
`485`	`481`	`}`