Merge pull request #9322 from m-kuhn/fix-double-delete

m-kuhn · web-flow · commit ac78a194dfb9 · 2019-03-02T09:46:55.000+01:00
[geometry validation] Fix double delete and memory leak
diff --git a/src/app/qgsgeometryvalidationdock.cpp b/src/app/qgsgeometryvalidationdock.cpp
@@ -335,7 +335,7 @@ void QgsGeometryValidationDock::showHighlight( const QModelIndex &current )
 
     QPropertyAnimation *errorAnimation = new QPropertyAnimation( mErrorRubberband, "fillColor" );
     errorAnimation->setEasingCurve( QEasingCurve::OutQuad );
-    connect( errorAnimation, &QPropertyAnimation::finished, featureAnimation, &QPropertyAnimation::deleteLater );
+    connect( errorAnimation, &QPropertyAnimation::finished, errorAnimation, &QPropertyAnimation::deleteLater );
     connect( errorAnimation, &QPropertyAnimation::valueChanged, this, [this]
     {
       mErrorRubberband->update();

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ void QgsGeometryValidationDock::showHighlight( const QModelIndex &current )`
`335`	`335`
`336`	`336`	`QPropertyAnimation *errorAnimation = new QPropertyAnimation( mErrorRubberband, "fillColor" );`
`337`	`337`	`errorAnimation->setEasingCurve( QEasingCurve::OutQuad );`
`338`		`- connect( errorAnimation, &QPropertyAnimation::finished, featureAnimation, &QPropertyAnimation::deleteLater );`
	`338`	`+ connect( errorAnimation, &QPropertyAnimation::finished, errorAnimation, &QPropertyAnimation::deleteLater );`
`339`	`339`	`connect( errorAnimation, &QPropertyAnimation::valueChanged, this, [this]`
`340`	`340`	`{`
`341`	`341`	`mErrorRubberband->update();`