Skip to content

Commit

Permalink
QgsRendererV2PropertiesDialog::syncToLayer(): make it robust to NULL …
Browse files Browse the repository at this point in the history
…renderer

Fixes #15064

Probably just a band-aid, proper fix to follow in OGR provider itself.
  • Loading branch information
rouault committed Jun 18, 2016
1 parent f354998 commit aceef9e
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions src/gui/symbology-ng/qgsrendererv2propertiesdialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,8 @@ void QgsRendererV2PropertiesDialog::syncToLayer()

// setup slot rendererChanged()
//setup order by
if ( mLayer->rendererV2()->orderByEnabled() )
if ( mLayer->rendererV2() &&
mLayer->rendererV2()->orderByEnabled() )
{
checkboxEnableOrderBy->setChecked( true );
}
Expand All @@ -343,14 +344,17 @@ void QgsRendererV2PropertiesDialog::syncToLayer()
}
lineEditOrderBy->setReadOnly( true );

// set current renderer from layer
QString rendererName = mLayer->rendererV2()->type();
if ( mLayer->rendererV2() )
{
// set current renderer from layer
QString rendererName = mLayer->rendererV2()->type();

int rendererIdx = cboRenderers->findData( rendererName );
cboRenderers->setCurrentIndex( rendererIdx );
int rendererIdx = cboRenderers->findData( rendererName );
cboRenderers->setCurrentIndex( rendererIdx );

// no renderer found... this mustn't happen
Q_ASSERT( rendererIdx != -1 && "there must be a renderer!" );
// no renderer found... this mustn't happen
Q_ASSERT( rendererIdx != -1 && "there must be a renderer!" );
}

}

Expand Down

0 comments on commit aceef9e

Please sign in to comment.