Navigation Menu

Skip to content

Commit

Permalink
don't crash when reply is destroyed while it's waiting for credentials
Browse files Browse the repository at this point in the history
to be entered

(backports 10a26e6)
  • Loading branch information
jef-n committed Apr 5, 2016
1 parent b3f8a85 commit ae162d6
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/app/qgisapp.cpp
Expand Up @@ -10238,8 +10238,9 @@ void QgisApp::namSetup()
#endif
}

void QgisApp::namAuthenticationRequired( QNetworkReply *reply, QAuthenticator *auth )
void QgisApp::namAuthenticationRequired( QNetworkReply *inReply, QAuthenticator *auth )
{
QPointer<QNetworkReply> reply( inReply );
QString username = auth->user();
QString password = auth->password();

Expand Down Expand Up @@ -10270,7 +10271,7 @@ void QgisApp::namAuthenticationRequired( QNetworkReply *reply, QAuthenticator *a
if ( !ok )
return;

if ( reply->isFinished() )
if ( reply.isNull() || reply->isFinished() )
return;

if ( auth->user() != username || ( password != auth->password() && !password.isNull() ) )
Expand Down

0 comments on commit ae162d6

Please sign in to comment.