Fix QgsReadWriteLocker changeMode

since mMode was never updated, the lock was never toggled from read to write or vice-versa. This was leading to crashes because the paths that were meant to be serialized and thread safe were not. Fixes #20789 and probably many more random crashes where QgsFeaturePool was used.
qgis · Dec 12, 2018 · b0d1506 · b0d1506
1 parent 6de0160
commit b0d1506
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/core/qgsreadwritelocker.cpp b/src/core/qgsreadwritelocker.cpp
@@ -34,6 +34,8 @@ void QgsReadWriteLocker::changeMode( QgsReadWriteLocker::Mode mode )
 
   unlock();
 
+  mMode = mode;
+
   if ( mMode == Read )
     mLock.lockForRead();
   else if ( mMode == Write )