Fix tests

src/core/layout/qgslayout.cpp

@@ -46,12 +46,22 @@ QgsLayout::~QgsLayout()
   // this class is deconstructed - to avoid segfaults
   // when layout items access in destructor layout that isn't valid anymore
 
+  // since deletion of some item types (e.g. groups) trigger deletion
+  // of other items, we have to do this careful, one at a time...
   QList<QGraphicsItem *> itemList = items();
-  while ( !itemList.empty() )
+  bool deleted = true;
+  while ( deleted )
   {
-    QGraphicsItem *item = itemList.at( 0 );
-    if ( dynamic_cast< QgsLayoutItem * >( item ) && !dynamic_cast< QgsLayoutItemPage *>( item ) )
-      delete item;
+    deleted = false;
+    for ( QGraphicsItem *item : qgsAsConst( itemList ) )
+    {
+      if ( dynamic_cast< QgsLayoutItem * >( item ) && !dynamic_cast< QgsLayoutItemPage *>( item ) )
+      {
+        delete item;
+        deleted = true;
+        break;
+      }
+    }
     itemList = items();
   }
 

src/core/layout/qgslayoutitemgroupundocommand.cpp

@@ -20,6 +20,7 @@
 #include "qgslayout.h"
 #include "qgsproject.h"
 
+///@cond PRIVATE
 QgsLayoutItemGroupUndoCommand::QgsLayoutItemGroupUndoCommand( State s, QgsLayoutItemGroup *group, QgsLayout *layout, const QString &text, QUndoCommand *parent )
   : QUndoCommand( text, parent )
   , mGroupUuid( group->uuid() )
@@ -84,3 +85,4 @@ void QgsLayoutItemGroupUndoCommand::switchState()
   }
   mLayout->project()->setDirty( true );
 }
+///@endcond

src/core/layout/qgslayoutitemgroupundocommand.h

@@ -23,6 +23,7 @@
 #include "qgslayoutitem.h"
 
 #define SIP_NO_FILE
+///@cond PRIVATE
 
 /**
  * \ingroup core
@@ -67,5 +68,6 @@ class CORE_EXPORT QgsLayoutItemGroupUndoCommand: public QObject, public QUndoCom
     //changes between added / removed state
     void switchState();
 };
+///@endcond
 
 #endif // QGSLAYOUTITEMGROUPUNDOCOMMAND_H