Skip to content
Permalink
Browse files

Apply suggestions from code review

Co-Authored-By: Matthias Kuhn <matthias@opengis.ch>
  • Loading branch information
3nids and m-kuhn committed Apr 30, 2020
1 parent fc3bb46 commit b97543d9ccb6cf3ee411d12ff1cdbd89d2319be9
@@ -1,5 +1,10 @@
#!/usr/bin/env bash

# This scripts renames the name of a class as well as its header and cpp file
# (assuming they are the lowercase version of the class name).
#
# Usage: ./scripts/rename_cpp.sh src/core QgsMyClassName QgsMyNewClassName

set -e

# GNU prefix command for mac os support (gsed, gsplit)
@@ -31,7 +31,7 @@
* \class QgsFieldExpressionValuesGatherer
* Gathers features with substring matching on an expression.
*
* \since QGIS 3.0
* \since QGIS 3.14
*/
class QgsFeatureExpressionValuesGatherer: public QThread
{
@@ -30,14 +30,14 @@ class CORE_EXPORT QgsFeatureFilterModel : public QgsFeaturePickerModelBase
Q_OBJECT

/**
* A field of sourceLayer that is unique and should be used to identify features.
* A set of fields of sourceLayer that is unique and should be used to identify features.
* Normally the primary key field.
* Needs to match the identifierValue.
*/
Q_PROPERTY( QStringList identifierFields READ identifierFields WRITE setIdentifierFields NOTIFY identifierFieldsChanged )

/**
* The value that identifies the current feature.
* The values that identifies the current feature.
*/
Q_PROPERTY( QVariantList extraIdentifierValues READ extraIdentifierValues WRITE setExtraIdentifierValues NOTIFY extraIdentifierValuesChanged )

@@ -121,10 +121,10 @@ void QgsExpressionPreviewWidget::refreshPreview()

void QgsExpressionPreviewWidget::linkActivated( const QString & )
{
QgsMessageViewer *mv = new QgsMessageViewer( this );
mv->setWindowTitle( tr( "More Info on Expression Error" ) );
mv->setMessageAsHtml( mToolTip );
mv->exec();
QgsMessageViewer mv( this );
mv.setWindowTitle( tr( "More Info on Expression Error" ) );
mv.setMessageAsHtml( mToolTip );
mv.exec();
}

void QgsExpressionPreviewWidget::setExpressionToolTip( const QString &toolTip )
@@ -163,4 +163,3 @@ bool QgsExpressionPreviewWidget::evalError() const
{
return mEvalError;
}

0 comments on commit b97543d

Please sign in to comment.
You can’t perform that action at this time.