Followup to b383c69. Keep labeling dialog from calling init() twice from vector props dialog

Author: dakcarto

src/app/qgisapp.cpp

@@ -4295,6 +4295,7 @@ void QgisApp::labeling()
   QDialog *dlg = new QDialog( this );
   dlg->setWindowTitle( tr( "Layer labeling settings" ) );
   QgsLabelingGui *labelingGui = new QgsLabelingGui( mLBL, vlayer, mMapCanvas, dlg );
+  labelingGui->init(); // load QgsPalLayerSettings for layer
   labelingGui->layout()->setContentsMargins( 0, 0, 0, 0 );
   QVBoxLayout *layout = new QVBoxLayout( dlg );
   layout->addWidget( labelingGui );

src/app/qgslabelinggui.cpp

@@ -184,9 +184,6 @@ QgsLabelingGui::QgsLabelingGui( QgsPalLabeling* lbl, QgsVectorLayer* layer, QgsM
   // TODO: is this necessary? maybe just use the data defined-only rotation?
   mPointAngleDDBtn->setVisible( false );
 
-  // load layer's current QgsPalLayerSettings
-  init();
-
   // Global settings group for groupboxes' saved/retored collapsed state
   // maintains state across different dialogs
   foreach ( QgsCollapsibleGroupBox *grpbox, findChildren<QgsCollapsibleGroupBox*>() )