Skip to content

Commit

Permalink
fix links to Qt issues
Browse files Browse the repository at this point in the history
  • Loading branch information
3nids committed May 7, 2018
1 parent cb00869 commit ba04dea
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/core/layout/qgslayoutexporter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -994,8 +994,8 @@ void QgsLayoutExporter::preparePrintAsPdf( QgsLayout *layout, QPrinter &printer,
// setOutputFormat should come after setOutputFileName, which auto-sets format to QPrinter::PdfFormat.
// [LS] This should be QPrinter::NativeFormat for Mac, otherwise fonts are not embed-able
// and text is not searchable; however, there are several bugs with <= Qt 4.8.5, 5.1.1, 5.2.0:
// https://bugreports.qt-project.org/browse/QTBUG-10094 - PDF font embedding fails
// https://bugreports.qt-project.org/browse/QTBUG-33583 - PDF output converts text to outline
// https://bugreports.qt.io/browse/QTBUG-10094 - PDF font embedding fails
// https://bugreports.qt.io/browse/QTBUG-33583 - PDF output converts text to outline
// Also an issue with PDF paper size using QPrinter::NativeFormat on Mac (always outputs portrait letter-size)
printer.setOutputFormat( QPrinter::PdfFormat );

Expand Down
4 changes: 2 additions & 2 deletions src/core/qgsfontutils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,8 @@ bool QgsFontUtils::loadStandardTestFonts( const QStringList &loadstyles )
{
// workaround for bugs with Qt 4.8.5 (other versions?) on Mac 10.9, where fonts
// from qrc resources load but fail to work and default font is substituted [LS]:
// https://bugreports.qt-project.org/browse/QTBUG-30917
// https://bugreports.qt-project.org/browse/QTBUG-32789
// https://bugreports.qt.io/browse/QTBUG-30917
// https://bugreports.qt.io/browse/QTBUG-32789
QString fontPath( QgsApplication::buildSourcePath() + "/tests/testdata/font/" + fontpath );
int fontID = QFontDatabase::addApplicationFont( fontPath );
loaded = ( fontID != -1 );
Expand Down
2 changes: 1 addition & 1 deletion src/core/qgsnetworkcontentfetcher.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ void QgsNetworkContentFetcher::cancel()
QTextCodec *QgsNetworkContentFetcher::codecForHtml( QByteArray &array ) const
{
//QTextCodec::codecForHtml fails to detect "<meta charset="utf-8"/>" type tags
//see https://bugreports.qt-project.org/browse/QTBUG-41011
//see https://bugreports.qt.io/browse/QTBUG-41011
//so test for that ourselves

//basic check
Expand Down
2 changes: 1 addition & 1 deletion src/gui/qgscolorswatchgrid.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ void QgsColorSwatchGridAction::setColor( const QColor &color )

void QgsColorSwatchGridAction::onHover()
{
//see https://bugreports.qt-project.org/browse/QTBUG-10427?focusedCommentId=185610&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-185610
//see https://bugreports.qt.io/browse/QTBUG-10427?focusedCommentId=185610&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-185610

if ( mSuppressRecurse )
{
Expand Down
2 changes: 1 addition & 1 deletion src/gui/qgscolorwidgets.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1685,7 +1685,7 @@ QgsColorWidgetAction::QgsColorWidgetAction( QgsColorWidget *colorWidget, QMenu *

void QgsColorWidgetAction::onHover()
{
//see https://bugreports.qt-project.org/browse/QTBUG-10427?focusedCommentId=185610&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-185610
//see https://bugreports.qt.io/browse/QTBUG-10427?focusedCommentId=185610&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-185610
if ( mSuppressRecurse )
{
return;
Expand Down
2 changes: 1 addition & 1 deletion src/gui/qgstextformatwidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ void QgsTextFormatWidget::populateFontCapitalsComboBox()
mFontCapitalsComboBox->addItem( tr( "All uppercase" ), QVariant( 1 ) );
mFontCapitalsComboBox->addItem( tr( "All lowercase" ), QVariant( 2 ) );
// Small caps doesn't work right with QPainterPath::addText()
// https://bugreports.qt-project.org/browse/QTBUG-13965
// https://bugreports.qt.io/browse/QTBUG-13965
// mFontCapitalsComboBox->addItem( tr( "Small caps" ), QVariant( 3 ) );
mFontCapitalsComboBox->addItem( tr( "Capitalize first letter" ), QVariant( 4 ) );
}
Expand Down
6 changes: 3 additions & 3 deletions src/plugins/grass/qtermwidget/Session.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ WId Session::windowId() const
// On Qt5, requesting window IDs breaks QQuickWidget and the likes,
// for example, see the following bug reports:
//
// https://bugreports.qt-project.org/browse/QTBUG-41779
// https://bugreports.qt-project.org/browse/QTBUG-40765
// https://bugreports.qt-project.org/browse/QTBUG-41942
// https://bugreports.qt.io/browse/QTBUG-41779
// https://bugreports.qt.io/browse/QTBUG-40765
// https://bugreports.qt.io/browse/QTBUG-41942

#if QT_VERSION >= QT_VERSION_CHECK(5, 0, 0)
return 0;
Expand Down
2 changes: 1 addition & 1 deletion src/providers/wms/qgswmsprovider.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2864,7 +2864,7 @@ QgsRasterIdentifyResult QgsWmsProvider::identify( const QgsPointXY &point, QgsRa
// Unfortunately the schema cannot be successfully loaded, it reports error
// "Element {http://www.opengis.net/gml}_Feature already defined"
// there is probably a bug in QXmlSchema:
// https://bugreports.qt-project.org/browse/QTBUG-8394
// https://bugreports.qt.io/browse/QTBUG-8394
// xmlpatternsvalidator gives the same error on XSD generated by OGR
if ( !schema.isValid() )
{
Expand Down

0 comments on commit ba04dea

Please sign in to comment.