Skip to content

Commit bb57cf4

Browse files
olivierdalangdakcarto
authored andcommitted
replaced "opacity" by "transparency" in the composer GUI
1 parent a882208 commit bb57cf4

File tree

3 files changed

+41
-41
lines changed

3 files changed

+41
-41
lines changed

src/app/composer/qgscomposeritemwidget.cpp

+21-21
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ void QgsComposerItemWidget::on_mBackgroundColorButton_clicked()
9797
}
9898

9999
mItem->beginCommand( tr( "Background color changed" ) );
100-
newBackgroundColor.setAlpha( mOpacitySlider->value() );
100+
newBackgroundColor.setAlpha( mTransparencySlider->value() );
101101
mItem->setBrush( QBrush( QColor( newBackgroundColor ), Qt::SolidPattern ) );
102102
//if the item is a composer map, we need to regenerate the map image
103103
//because it usually is cached
@@ -110,38 +110,38 @@ void QgsComposerItemWidget::on_mBackgroundColorButton_clicked()
110110
mItem->endCommand();
111111
}
112112

113-
void QgsComposerItemWidget::on_mOpacitySpinBox_valueChanged( int value )
113+
void QgsComposerItemWidget::on_mTransparencySpinBox_valueChanged( int value )
114114
{
115115
if ( !mItem )
116116
{
117117
return;
118118
}
119119

120-
mOpacitySlider->blockSignals( true );
121-
mOpacitySlider->setValue( value );
122-
mOpacitySlider->blockSignals( false );
123-
changeItemOpacity( value );
120+
mTransparencySlider->blockSignals( true );
121+
mTransparencySlider->setValue( value );
122+
mTransparencySlider->blockSignals( false );
123+
changeItemTransparency( value );
124124
}
125125

126-
void QgsComposerItemWidget::on_mOpacitySlider_sliderReleased()
126+
void QgsComposerItemWidget::on_mTransparencySlider_sliderReleased()
127127
{
128128
if ( !mItem )
129129
{
130130
return;
131131
}
132-
int value = mOpacitySlider->value();
133-
mOpacitySpinBox->blockSignals( true );
134-
mOpacitySpinBox->setValue( value );
135-
mOpacitySpinBox->blockSignals( false );
136-
changeItemOpacity( value );
132+
int value = mTransparencySlider->value();
133+
mTransparencySpinBox->blockSignals( true );
134+
mTransparencySpinBox->setValue( value );
135+
mTransparencySpinBox->blockSignals( false );
136+
changeItemTransparency( value );
137137
}
138138

139-
void QgsComposerItemWidget::changeItemOpacity( int value )
139+
void QgsComposerItemWidget::changeItemTransparency( int value )
140140
{
141-
mItem->beginCommand( tr( "Item opacity changed" ) );
141+
mItem->beginCommand( tr( "Item Transparency changed" ) );
142142
QBrush itemBrush = mItem->brush();
143143
QColor brushColor = itemBrush.color();
144-
brushColor.setAlpha( value );
144+
brushColor.setAlpha( 255-value );
145145
mItem->setBrush( QBrush( brushColor ) );
146146
mItem->update();
147147
mItem->endCommand();
@@ -347,26 +347,26 @@ void QgsComposerItemWidget::setValuesForGuiElements()
347347

348348
setValuesForGuiPositionElements();
349349

350-
mOpacitySlider->blockSignals( true );
350+
mTransparencySlider->blockSignals( true );
351351
mOutlineWidthSpinBox->blockSignals( true );
352352
mFrameGroupBox->blockSignals( true );
353353
mBackgroundGroupBox->blockSignals( true );
354354
mItemIdLineEdit->blockSignals( true );
355-
mOpacitySpinBox->blockSignals( true );
355+
mTransparencySpinBox->blockSignals( true );
356356

357-
mOpacitySpinBox->setValue( mItem->brush().color().alpha() );
358-
mOpacitySlider->setValue( mItem->brush().color().alpha() );
357+
mTransparencySpinBox->setValue( 255-mItem->brush().color().alpha() );
358+
mTransparencySlider->setValue( 255-mItem->brush().color().alpha() );
359359
mOutlineWidthSpinBox->setValue( mItem->pen().widthF() );
360360
mItemIdLineEdit->setText( mItem->id() );
361361
mFrameGroupBox->setChecked( mItem->hasFrame() );
362362
mBackgroundGroupBox->setChecked( mItem->hasBackground() );
363363

364-
mOpacitySlider->blockSignals( false );
364+
mTransparencySlider->blockSignals( false );
365365
mOutlineWidthSpinBox->blockSignals( false );
366366
mFrameGroupBox->blockSignals( false );
367367
mBackgroundGroupBox->blockSignals( false );
368368
mItemIdLineEdit->blockSignals( false );
369-
mOpacitySpinBox->blockSignals( false );
369+
mTransparencySpinBox->blockSignals( false );
370370
}
371371

372372
void QgsComposerItemWidget::on_mItemIdLineEdit_textChanged( const QString &text )

src/app/composer/qgscomposeritemwidget.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ class QgsComposerItemWidget: public QWidget, private Ui::QgsComposerItemWidgetBa
3939
public slots:
4040
void on_mFrameColorButton_clicked();
4141
void on_mBackgroundColorButton_clicked();
42-
void on_mOpacitySlider_sliderReleased();
43-
void on_mOpacitySpinBox_valueChanged( int value );
42+
void on_mTransparencySlider_sliderReleased();
43+
void on_mTransparencySpinBox_valueChanged( int value );
4444
void on_mOutlineWidthSpinBox_valueChanged( double d );
4545
void on_mFrameGroupBox_toggled( bool state );
4646
void on_mBackgroundGroupBox_toggled( bool state );
@@ -67,7 +67,7 @@ class QgsComposerItemWidget: public QWidget, private Ui::QgsComposerItemWidgetBa
6767

6868
private:
6969
QgsComposerItemWidget();
70-
void changeItemOpacity( int value );
70+
void changeItemTransparency( int value );
7171
void changeItemPosition();
7272

7373
QgsComposerItem* mItem;

src/ui/qgscomposeritemwidgetbase.ui

+17-17
Original file line numberDiff line numberDiff line change
@@ -310,14 +310,20 @@
310310
<item>
311311
<layout class="QHBoxLayout" name="horizontalLayout_2">
312312
<item>
313-
<widget class="QSpinBox" name="mOpacitySpinBox">
314-
<property name="maximum">
315-
<number>255</number>
313+
<widget class="QLabel" name="mOpacityLabel">
314+
<property name="text">
315+
<string>Transparency</string>
316+
</property>
317+
<property name="wordWrap">
318+
<bool>true</bool>
319+
</property>
320+
<property name="buddy">
321+
<cstring>mTransparencySlider</cstring>
316322
</property>
317323
</widget>
318324
</item>
319325
<item>
320-
<widget class="QSlider" name="mOpacitySlider">
326+
<widget class="QSlider" name="mTransparencySlider">
321327
<property name="maximum">
322328
<number>255</number>
323329
</property>
@@ -327,15 +333,9 @@
327333
</widget>
328334
</item>
329335
<item>
330-
<widget class="QLabel" name="mOpacityLabel">
331-
<property name="text">
332-
<string>Opacity</string>
333-
</property>
334-
<property name="wordWrap">
335-
<bool>true</bool>
336-
</property>
337-
<property name="buddy">
338-
<cstring>mOpacitySlider</cstring>
336+
<widget class="QSpinBox" name="mTransparencySpinBox">
337+
<property name="maximum">
338+
<number>255</number>
339339
</property>
340340
</widget>
341341
</item>
@@ -404,9 +404,9 @@
404404
<resources/>
405405
<connections>
406406
<connection>
407-
<sender>mOpacitySlider</sender>
407+
<sender>mTransparencySlider</sender>
408408
<signal>valueChanged(int)</signal>
409-
<receiver>mOpacitySpinBox</receiver>
409+
<receiver>mTransparencySpinBox</receiver>
410410
<slot>setValue(int)</slot>
411411
<hints>
412412
<hint type="sourcelabel">
@@ -420,9 +420,9 @@
420420
</hints>
421421
</connection>
422422
<connection>
423-
<sender>mOpacitySpinBox</sender>
423+
<sender>mTransparencySpinBox</sender>
424424
<signal>valueChanged(int)</signal>
425-
<receiver>mOpacitySlider</receiver>
425+
<receiver>mTransparencySlider</receiver>
426426
<slot>setValue(int)</slot>
427427
<hints>
428428
<hint type="sourcelabel">

0 commit comments

Comments
 (0)