Skip to content

Commit bcbdd7c

Browse files
committed
use QEXPECT_FAIL instead of disabling the test
1 parent 4e4f6fe commit bcbdd7c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/core/symbology-ng/qgsstylev2.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ bool QgsStyleV2::save( QString filename )
336336
filename = mFileName;
337337

338338
// TODO evaluate the requirement of this function and change implementation accordingly
339-
// TODO enable save TestStyleV2::testSaveLoad()
339+
// TODO remove QEXPECT_FAIL from TestStyleV2::testSaveLoad() when done
340340
#if 0
341341
QDomDocument doc( "qgis_style" );
342342
QDomElement root = doc.createElement( "qgis_style" );

tests/src/core/testqgsstylev2.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,8 @@ void TestStyleV2::testLoadColorRamps()
188188

189189
void TestStyleV2::testSaveLoad()
190190
{
191-
#if 0
191+
QEXPECT_FAIL("", "save() currently disabled in core", Abort);
192+
192193
mStyle->save();
193194
mStyle->clear();
194195
mStyle->load( QgsApplication::userStyleV2Path() );
@@ -205,7 +206,6 @@ void TestStyleV2::testSaveLoad()
205206
if ( ramp )
206207
delete ramp;
207208
}
208-
#endif
209209
}
210210

211211

0 commit comments

Comments
 (0)