Fix clazy return void warnings

src/analysis/vector/qgsgeometrysnapper.h

@@ -96,7 +96,7 @@ class ANALYSIS_EXPORT QgsGeometrySnapper : public QObject
         , snapTolerance( snapTolerance )
         , mode( mode )
       {}
-      void operator()( QgsFeature &feature ) { return instance->processFeature( feature, snapTolerance, mode ); }
+      void operator()( QgsFeature &feature ) { instance->processFeature( feature, snapTolerance, mode ); }
     };
 
     enum PointFlag { SnappedToRefNode, SnappedToRefSegment, Unsnapped };

src/core/qgssettings.cpp

@@ -189,7 +189,7 @@ QString QgsSettings::fileName() const
 
 void QgsSettings::sync()
 {
-  return mUserSettings->sync();
+  mUserSettings->sync();
 }
 
 void QgsSettings::remove( const QString &key, const QgsSettings::Section section )

src/core/symbology/qgspointdistancerenderer.cpp

@@ -193,7 +193,7 @@ void QgsPointDistanceRenderer::checkLegendSymbolItem( const QString &key, bool s
   if ( !mRenderer )
     return;
 
-  return mRenderer->checkLegendSymbolItem( key, state );
+  mRenderer->checkLegendSymbolItem( key, state );
 }
 
 QString QgsPointDistanceRenderer::filter( const QgsFields &fields )

src/gui/qgsrasterlayersaveasdialog.h

@@ -87,7 +87,7 @@ class GUI_EXPORT QgsRasterLayerSaveAsDialog: public QDialog, private Ui::QgsRast
     void hideOutput();
 
   public slots:
-    void accept() override { if ( validate() ) return QDialog::accept(); }
+    void accept() override { if ( validate() ) QDialog::accept(); }
 
   private slots:
     void mRawModeRadioButton_toggled( bool );

src/gui/qgsscalewidget.cpp

@@ -61,5 +61,5 @@ void QgsScaleWidget::setScaleFromCanvas()
 
 void QgsScaleWidget::setScale( double scale )
 {
-  return mScaleComboBox->setScale( scale );
+  mScaleComboBox->setScale( scale );
 }