Skip to content

Commit c063838

Browse files
committed
rename QgsFilePickerWidget to QgsFileWidget
1 parent 36157d4 commit c063838

17 files changed

+200
-189
lines changed

python/gui/gui.sip

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
%Include qgsfieldproxymodel.sip
7474
%Include qgsfieldvalidator.sip
7575
%Include qgsfiledropedit.sip
76-
%Include qgsfilepickerwidget.sip
76+
%Include qgsfilewidget.sip
7777
%Include qgsfilterlineedit.sip
7878
%Include qgsformannotationitem.sip
7979
%Include qgsgenericprojectionselector.sip

python/gui/qgsexternalresourcewidget.sip

+24-13
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,19 @@ class QgsExternalResourceWidget : QWidget
77

88
public:
99

10-
enum DocumentViewerContent
10+
enum DocumentViewerContent
1111
{
1212
NoContent,
1313
Image,
1414
Web
1515
};
1616

17-
explicit QgsExternalResourceWidget( QWidget* parent /TransferThis/ );
18-
19-
~QgsExternalResourceWidget();
17+
/**
18+
* @brief QgsExternalResourceWidget creates a widget with a file widget and a document viewer
19+
* Both part of the widget are optional.
20+
* @see QgsFileWidget
21+
*/
22+
explicit QgsExternalResourceWidget( QWidget *parent = 0 );
2023

2124
/**
2225
* @brief documentPath returns the path of the current document in the widget
@@ -25,30 +28,38 @@ class QgsExternalResourceWidget : QWidget
2528
QVariant documentPath( QVariant::Type type = QVariant::String ) const;
2629
void setDocumentPath( QVariant documentPath );
2730

28-
//! access the file picker widget to allow its configuration
29-
QgsFilePickerWidget* filePickerwidget();
31+
//! access the file widget to allow its configuration
32+
QgsFileWidget* fileWidget();
3033

31-
//! returns if the file picker is visible in the widget
32-
bool filePickerVisible() const;
33-
//! set the visiblity of the file picker in the widget
34-
void setFilePickerVisible( bool visible );
34+
//! returns if the file widget is visible in the widget
35+
bool fileWidgetVisible() const;
36+
//! set the visiblity of the file widget in the layout
37+
void setFileWidgetVisible( bool visible );
3538

3639
//! returns the type of content used in the document viewer
3740
QgsExternalResourceWidget::DocumentViewerContent documentViewerContent() const;
3841
//! setDocumentViewerContent defines the type of content to be shown. Widget will be adapated accordingly
3942
void setDocumentViewerContent( QgsExternalResourceWidget::DocumentViewerContent content );
4043

41-
//! set the configuration of the document viewer
44+
//! returns the height of the document viewer
4245
int documentViewerHeight() const;
46+
/**
47+
* @brief setDocumentViewerWidth set the height of the document viewer.
48+
* @param height the height. Use 0 for automatic best display.
49+
*/
4350
void setDocumentViewerHeight( int height );
51+
//! returns the width of the document viewer
4452
int documentViewerWidth() const ;
53+
/**
54+
* @brief setDocumentViewerWidth set the width of the document viewer.
55+
* @param width the width. Use 0 for automatic best display.
56+
*/
4557
void setDocumentViewerWidth( int width );
4658

4759
//! defines if the widget is readonly
4860
void setReadOnly( bool readOnly );
4961

5062
signals:
63+
//! emitteed as soon as the current document changes
5164
void valueChanged( QString );
52-
53-
5465
};

python/gui/qgsfilepickerwidget.sip renamed to python/gui/qgsfilewidget.sip

+10-10
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11

2-
class QgsFilePickerWidget : QWidget
2+
class QgsFileWidget : QWidget
33
{
44
%TypeHeaderCode
5-
#include <qgsfilepickerwidget.h>
5+
#include <qgsfilewidget.h>
66
%End
77

88
public:
@@ -20,9 +20,9 @@ class QgsFilePickerWidget : QWidget
2020
RelativeDefaultPath
2121
};
2222

23-
explicit QgsFilePickerWidget( QWidget* parent /TransferThis/ );
23+
explicit QgsFileWidget( QWidget* parent /TransferThis/ );
2424

25-
~QgsFilePickerWidget();
25+
~QgsFileWidget();
2626

2727
//! Returns the current file path
2828
QString filePath();
@@ -50,9 +50,9 @@ class QgsFilePickerWidget : QWidget
5050
void setFilter( const QString &filter );
5151

5252
//! determines if the tool button is shown
53-
bool filePickerButtonVisible() const;
53+
bool fileWidgetButtonVisible() const;
5454
//! determines if the tool button is shown
55-
void setFilePickerButtonVisible( bool visible );
55+
void setFileWidgetButtonVisible( bool visible );
5656

5757
//! determines if the file path will be shown as a link
5858
bool useLink() const;
@@ -68,12 +68,12 @@ class QgsFilePickerWidget : QWidget
6868
void setDefaultRoot( QString defaultRoot );
6969

7070
//! determines the storage mode (i.e. file or directory)
71-
QgsFilePickerWidget::StorageMode storageMode() const;
72-
void setStorageMode( QgsFilePickerWidget::StorageMode storageMode );
71+
QgsFileWidget::StorageMode storageMode() const;
72+
void setStorageMode( QgsFileWidget::StorageMode storageMode );
7373

7474
//! determines if the relative path is with respect to the project path or the default path
75-
QgsFilePickerWidget::RelativeStorage relativeStorage() const;
76-
void setRelativeStorage( QgsFilePickerWidget::RelativeStorage relativeStorage );
75+
QgsFileWidget::RelativeStorage relativeStorage() const;
76+
void setRelativeStorage( QgsFileWidget::RelativeStorage relativeStorage );
7777

7878
signals:
7979
void fileChanged( QString );

src/customwidgets/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ SET (QGIS_CUSTOMWIDGETS_SRCS
3434
qgsexternalresourcewidgetplugin.cpp
3535
qgsfieldcomboboxplugin.cpp
3636
qgsfieldexpressionwidgetplugin.cpp
37-
qgsfilepickerwidgetplugin.cpp
37+
qgsfilewidgetplugin.cpp
3838
qgsfilterlineeditplugin.cpp
3939
qgsmaplayercomboboxplugin.cpp
4040
qgsprojectionselectionwidgetplugin.cpp
@@ -58,7 +58,7 @@ SET (QGIS_CUSTOMWIDGETS_MOC_HDRS
5858
qgsexternalresourcewidgetplugin.h
5959
qgsfieldcomboboxplugin.h
6060
qgsfieldexpressionwidgetplugin.h
61-
qgsfilepickerwidgetplugin.h
61+
qgsfilewidgetplugin.h
6262
qgsfilterlineeditplugin.h
6363
qgsmaplayercomboboxplugin.h
6464
qgsprojectionselectionwidgetplugin.h
@@ -88,7 +88,7 @@ SET(QGIS_CUSTOMWIDGETS_HDRS
8888
qgsexternalresourcewidgetplugin.h
8989
qgsfieldcomboboxplugin.h
9090
qgsfieldexpressionwidgetplugin.h
91-
qgsfilepickerwidgetplugin.h
91+
qgsfilewidgetplugin.h
9292
qgsfilterlineeditplugin.h
9393
qgsmaplayercomboboxplugin.h
9494
qgsprojectionselectionwidgetplugin.h

src/customwidgets/qgsfilepickerwidgetplugin.cpp renamed to src/customwidgets/qgsfilewidgetplugin.cpp

+19-19
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/***************************************************************************
2-
qgsfilepickerwidgetplugin.cpp
2+
qgsfilewidgetplugin.cpp
33
--------------------------------------
44
Date : 13.01.2016
55
Copyright : (C) 2016 Denis Rouzaud
@@ -14,52 +14,52 @@
1414
***************************************************************************/
1515

1616
#include "qgiscustomwidgets.h"
17-
#include "qgsfilepickerwidgetplugin.h"
18-
#include "qgsfilepickerwidget.h"
17+
#include "qgsfilewidgetplugin.h"
18+
#include "qgsfilewidget.h"
1919

2020

21-
QgsFilePickerWidgetPlugin::QgsFilePickerWidgetPlugin( QObject *parent )
21+
QgsFileWidgetPlugin::QgsFileWidgetPlugin( QObject *parent )
2222
: QObject( parent )
2323
, mInitialized( false )
2424
{
2525
}
2626

27-
QString QgsFilePickerWidgetPlugin::name() const
27+
QString QgsFileWidgetPlugin::name() const
2828
{
29-
return "QgsFilePickerWidget";
29+
return "QgsFileWidget";
3030
}
3131

32-
QString QgsFilePickerWidgetPlugin::group() const
32+
QString QgsFileWidgetPlugin::group() const
3333
{
3434
return QgisCustomWidgets::groupName();
3535
}
3636

37-
QString QgsFilePickerWidgetPlugin::includeFile() const
37+
QString QgsFileWidgetPlugin::includeFile() const
3838
{
39-
return "qgsfilepickerwidget.h";
39+
return "qgsfilewidget.h";
4040
}
4141

42-
QIcon QgsFilePickerWidgetPlugin::icon() const
42+
QIcon QgsFileWidgetPlugin::icon() const
4343
{
4444
return QIcon( ":/images/icons/qgis-icon-60x60.png" );
4545
}
4646

47-
bool QgsFilePickerWidgetPlugin::isContainer() const
47+
bool QgsFileWidgetPlugin::isContainer() const
4848
{
4949
return false;
5050
}
5151

52-
QWidget *QgsFilePickerWidgetPlugin::createWidget( QWidget *parent )
52+
QWidget *QgsFileWidgetPlugin::createWidget( QWidget *parent )
5353
{
54-
return new QgsFilePickerWidget( parent );
54+
return new QgsFileWidget( parent );
5555
}
5656

57-
bool QgsFilePickerWidgetPlugin::isInitialized() const
57+
bool QgsFileWidgetPlugin::isInitialized() const
5858
{
5959
return mInitialized;
6060
}
6161

62-
void QgsFilePickerWidgetPlugin::initialize( QDesignerFormEditorInterface *core )
62+
void QgsFileWidgetPlugin::initialize( QDesignerFormEditorInterface *core )
6363
{
6464
Q_UNUSED( core );
6565
if ( mInitialized )
@@ -68,20 +68,20 @@ void QgsFilePickerWidgetPlugin::initialize( QDesignerFormEditorInterface *core )
6868
}
6969

7070

71-
QString QgsFilePickerWidgetPlugin::toolTip() const
71+
QString QgsFileWidgetPlugin::toolTip() const
7272
{
7373
return "";
7474
}
7575

76-
QString QgsFilePickerWidgetPlugin::whatsThis() const
76+
QString QgsFileWidgetPlugin::whatsThis() const
7777
{
7878
return "";
7979
}
8080

81-
QString QgsFilePickerWidgetPlugin::domXml() const
81+
QString QgsFileWidgetPlugin::domXml() const
8282
{
8383
return QString( "<ui language=\"c++\">\n"
84-
" <widget class=\"%1\" name=\"mQgsFilePickerWidget\">\n"
84+
" <widget class=\"%1\" name=\"mQgsFileWidget\">\n"
8585
" <property name=\"geometry\">\n"
8686
" <rect>\n"
8787
" <x>0</x>\n"

src/customwidgets/qgsfilepickerwidgetplugin.h renamed to src/customwidgets/qgsfilewidgetplugin.h

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/***************************************************************************
2-
qgsfilepickerwidgetplugin.h
2+
qgsfilewidgetplugin.h
33
--------------------------------------
44
Date : 13.01.2016
55
Copyright : (C) 2016 Denis Rouzaud
@@ -13,8 +13,8 @@
1313
* *
1414
***************************************************************************/
1515

16-
#ifndef QGSFILEPICKERWIDGETPLUGIN_H
17-
#define QGSFILEPICKERWIDGETPLUGIN_H
16+
#ifndef QGSFILEWIDGETPLUGIN_H
17+
#define QGSFILEWIDGETPLUGIN_H
1818

1919

2020
#include <QtGlobal>
@@ -27,13 +27,13 @@
2727
#endif
2828

2929

30-
class CUSTOMWIDGETS_EXPORT QgsFilePickerWidgetPlugin : public QObject, public QDesignerCustomWidgetInterface
30+
class CUSTOMWIDGETS_EXPORT QgsFileWidgetPlugin : public QObject, public QDesignerCustomWidgetInterface
3131
{
3232
Q_OBJECT
3333
Q_INTERFACES( QDesignerCustomWidgetInterface )
3434

3535
public:
36-
explicit QgsFilePickerWidgetPlugin( QObject *parent = 0 );
36+
explicit QgsFileWidgetPlugin( QObject *parent = 0 );
3737

3838
private:
3939
bool mInitialized;
@@ -52,4 +52,4 @@ class CUSTOMWIDGETS_EXPORT QgsFilePickerWidgetPlugin : public QObject, public QD
5252
QString whatsThis() const override;
5353
QString domXml() const override;
5454
};
55-
#endif // QGSFILEPICKERWIDGETPLUGIN_H
55+
#endif // QGSFILEWIDGETPLUGIN_H

src/gui/CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ SET(QGIS_GUI_SRCS
198198
qgsfieldproxymodel.cpp
199199
qgsfieldvalidator.cpp
200200
qgsfiledropedit.cpp
201-
qgsfilepickerwidget.cpp
201+
qgsfilewidget.cpp
202202
qgsfilterlineedit.cpp
203203
qgsformannotationitem.cpp
204204
qgsgenericprojectionselector.cpp
@@ -338,7 +338,7 @@ SET(QGIS_GUI_MOC_HDRS
338338
qgsfieldproxymodel.h
339339
qgsfieldvalidator.h
340340
qgsfiledropedit.h
341-
qgsfilepickerwidget.h
341+
qgsfilewidget.h
342342
qgsfilterlineedit.h
343343
qgsformannotationitem.h
344344
qgsgenericprojectionselector.h

src/gui/editorwidgets/qgsexternalresourceconfigdlg.cpp

+15-15
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,13 @@ QgsExternalResourceConfigDlg::QgsExternalResourceConfigDlg( QgsVectorLayer* vl,
4343
connect( mRelativeGroupBox, SIGNAL( toggled( bool ) ), this, SLOT( enableRelative( bool ) ) );
4444

4545
// set ids for StorageTypeButtons
46-
mStorageButtonGroup->setId( mStoreFilesButton, QgsFilePickerWidget::GetFile );
47-
mStorageButtonGroup->setId( mStoreDirsButton, QgsFilePickerWidget::GetDirectory );
46+
mStorageButtonGroup->setId( mStoreFilesButton, QgsFileWidget::GetFile );
47+
mStorageButtonGroup->setId( mStoreDirsButton, QgsFileWidget::GetDirectory );
4848
mStoreFilesButton->setChecked( true );
4949

5050
// set ids for RelativeButtons
51-
mRelativeButtonGroup->setId( mRelativeProject, QgsFilePickerWidget::RelativeProject );
52-
mRelativeButtonGroup->setId( mRelativeDefault, QgsFilePickerWidget::RelativeDefaultPath );
51+
mRelativeButtonGroup->setId( mRelativeProject, QgsFileWidget::RelativeProject );
52+
mRelativeButtonGroup->setId( mRelativeDefault, QgsFileWidget::RelativeDefaultPath );
5353
mRelativeProject->setChecked( true );
5454

5555
mDocumentViewerContentComboBox->addItem( tr( "Image" ), QgsExternalResourceWidget::Image );
@@ -109,9 +109,9 @@ QgsEditorWidgetConfig QgsExternalResourceConfigDlg::config()
109109
{
110110
QgsEditorWidgetConfig cfg;
111111

112-
cfg.insert( "FilePicker", mFilePickerGroupBox->isChecked() );
113-
cfg.insert( "FilePickerButton", mFilePickerButtonGroupBox->isChecked() );
114-
cfg.insert( "FilePickerFilter", mFilePickerFilterLineEdit->text() );
112+
cfg.insert( "FileWidget", mFileWidgetGroupBox->isChecked() );
113+
cfg.insert( "FileWidgetButton", mFileWidgetButtonGroupBox->isChecked() );
114+
cfg.insert( "FileWidgetFilter", mFileWidgetFilterLineEdit->text() );
115115

116116
if ( mUseLink->isChecked() )
117117
{
@@ -135,7 +135,7 @@ QgsEditorWidgetConfig QgsExternalResourceConfigDlg::config()
135135
}
136136
else
137137
{
138-
cfg.insert( "RelativeStorage", ( int )QgsFilePickerWidget::Absolute );
138+
cfg.insert( "RelativeStorage", ( int )QgsFileWidget::Absolute );
139139
}
140140

141141
if ( mDocumentViewerGroupBox->isChecked() )
@@ -155,17 +155,17 @@ QgsEditorWidgetConfig QgsExternalResourceConfigDlg::config()
155155

156156
void QgsExternalResourceConfigDlg::setConfig( const QgsEditorWidgetConfig& config )
157157
{
158-
if ( config.contains( "FilePicker" ) )
158+
if ( config.contains( "FileWidget" ) )
159159
{
160-
mFilePickerGroupBox->setChecked( config.value( "FilePicker" ).toBool() );
160+
mFileWidgetGroupBox->setChecked( config.value( "FileWidget" ).toBool() );
161161
}
162-
if ( config.contains( "FilePicker" ) )
162+
if ( config.contains( "FileWidget" ) )
163163
{
164-
mFilePickerButtonGroupBox->setChecked( config.value( "FilePickerButton" ).toBool() );
164+
mFileWidgetButtonGroupBox->setChecked( config.value( "FileWidgetButton" ).toBool() );
165165
}
166-
if ( config.contains( "FilePickerFilter" ) )
166+
if ( config.contains( "FileWidgetFilter" ) )
167167
{
168-
mFilePickerFilterLineEdit->setText( config.value( "Filter" ).toString() );
168+
mFileWidgetFilterLineEdit->setText( config.value( "Filter" ).toString() );
169169
}
170170

171171
if ( config.contains( "UseLink" ) )
@@ -184,7 +184,7 @@ void QgsExternalResourceConfigDlg::setConfig( const QgsEditorWidgetConfig& confi
184184
if ( config.contains( "RelativeStorage" ) )
185185
{
186186
int relative = config.value( "RelativeStorage" ).toInt();
187-
if (( QgsFilePickerWidget::RelativeStorage )relative == QgsFilePickerWidget::Absolute )
187+
if (( QgsFileWidget::RelativeStorage )relative == QgsFileWidget::Absolute )
188188
{
189189
mRelativeGroupBox->setChecked( false );
190190
}

0 commit comments

Comments
 (0)