Skip to content

Commit c2118e7

Browse files
committed
DBManager: remove label from separators (fix #5393)
1 parent f11878b commit c2118e7

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

python/plugins/db_manager/db_manager.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ def registerAction(self, action, menuName, callback=None):
223223
# get the placeholder's position to insert before it
224224
pos = 0
225225
for pos in range(len(menuActions)):
226-
if menuActions[pos].isSeparator() and menuActions[pos].text() == "placeholder":
226+
if menuActions[pos].isSeparator() and menuActions[pos].objectName().endsWith("_placeholder"):
227227
menuActions[pos].setVisible(True)
228228
break
229229

@@ -301,7 +301,7 @@ def unregisterAction(self, action, menuName):
301301
# hide the placeholder if there're no other registered actions
302302
if len(self._registeredDbActions[menuName]) <= 0:
303303
for i in range(len(menuActions)):
304-
if menuActions[i].isSeparator() and menuActions[i].text() == "placeholder":
304+
if menuActions[i].isSeparator() and menuActions[i].objectName().endsWith("_placeholder"):
305305
menuActions[i].setVisible(False)
306306
break
307307

@@ -369,18 +369,18 @@ def setupUi(self):
369369
# create menus' actions
370370

371371
# menu DATABASE
372-
sep = self.menuDb.addAction("placeholder"); sep.setSeparator(True); sep.setVisible(False)
372+
sep = self.menuDb.addSeparator(); sep.setObjectName("DB_Manager_DbMenu_placeholder"); sep.setVisible(False)
373373
self.actionRefresh = self.menuDb.addAction( QIcon(":/db_manager/actions/refresh"), "&Refresh", self.refreshActionSlot, QKeySequence("F5") )
374374
self.actionSqlWindow = self.menuDb.addAction( QIcon(":/db_manager/actions/sql_window"), "&SQL window", self.runSqlWindow, QKeySequence("F2") )
375375
self.menuDb.addSeparator()
376376
self.actionClose = self.menuDb.addAction( QIcon(), "&Exit", self.close, QKeySequence("CTRL+Q") )
377377

378378
# menu SCHEMA
379-
sep = self.menuSchema.addAction("placeholder"); sep.setSeparator(True); sep.setVisible(False)
379+
sep = self.menuSchema.addSeparator(); sep.setObjectName("DB_Manager_SchemaMenu_placeholder"); sep.setVisible(False)
380380
actionMenuSchema.setVisible(False)
381381

382382
# menu TABLE
383-
sep = self.menuTable.addAction("placeholder"); sep.setSeparator(True); sep.setVisible(False)
383+
sep = self.menuTable.addSeparator(); sep.setObjectName("DB_Manager_TableMenu_placeholder"); sep.setVisible(False)
384384
actionMenuTable.setVisible(False)
385385
self.actionShowSystemTables = self.menuTable.addAction("Show system tables/views", self.showSystemTables)
386386
self.actionShowSystemTables.setCheckable(True)

0 commit comments

Comments
 (0)