Skip to content

Commit

Permalink
Remove empty item from plugin manager tabs
Browse files Browse the repository at this point in the history
  • Loading branch information
@nyalldawson
nyalldawson committed Oct 18, 2017
1 parent 5a14a92 commit c295c92
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions src/ui/qgspluginmanagerbase.ui
View file
Original file line number Diff line number Diff line change
Expand Up @@ -188,18 +188,6 @@
<set>ItemIsSelectable|ItemIsEnabled</set>
</property>
</item>
<item>
<property name="text">
<string/>
</property>
<property name="icon">
<iconset resource="../../images/images.qrc">
<normaloff>:/images/themes/default/propertyicons/spacer.svg</normaloff>:/images/themes/default/propertyicons/spacer.svg</iconset>
</property>
<property name="flags">
<set>NoItemFlags</set>
</property>
</item>
<item>
<property name="text">
<string>Install from ZIP</string>
Expand Down

3 comments on commit c295c92

@rduivenvoorde
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson @borysiasty removing this breaks tab behaviour: it does not show the right tabs anymore now :-(

@rduivenvoorde
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson @borysiasty currently you cannot see the plugin manager settings...

And I'm not able to use the 'install from zip' here on a windows machine today's master.
I downloaded the plugin zip:
http://plugins.qgis.org/plugins/pdokservicesplugin/version/0.14/download/
or (experimental should be enabled):
http://plugins.qgis.org/plugins/pdoklocator/version/0.1/download/

All seems fine, but after clicking the 'Install plugin' nothing happens, no apparent install, and no error?

OR is it related to this tabs being wrong?

@borysiasty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rduivenvoorde - yes, removing the spacer item changed the tab numbers, so you just need to click "Settings" in order to get the "Install from zip" :) And "Settings" are currently not available.

@nyalldawson - what do you propose instead of the spacer? Let's discuss it in qgis/qgis3_UIX_discussion#24

Please sign in to comment.