Skip to content
Permalink
Browse files

Followups

  • Loading branch information
nyalldawson committed Apr 26, 2018
1 parent c78bdae commit c3b69900f78273d337bb895c63cf8ec0c817585c
Showing with 1 addition and 3 deletions.
  1. +1 −1 src/providers/oracle/qgsoracleprovider.cpp
  2. +0 −2 tests/src/python/test_provider_oracle.py
@@ -1301,7 +1301,7 @@ bool QgsOracleProvider::addFeatures( QgsFeatureList &flist, QgsFeatureSink::Flag
QVariant value = attributevec.value( fieldId[i], QVariant() );

QString v;
if ( !value.isValid() || value.isNull() )
if ( value.isNull() )
{
if ( mPrimaryKeyAttrs.contains( i ) && !defaultValues.at( i ).isEmpty() )
{
@@ -63,7 +63,6 @@ def execSQLCommand(self, sql, ignore_errors=False):
self.assertTrue(query.exec_(sql), sql + ': ' + query.lastError().text())
query.finish()

# disabled: WIP
def getSource(self):
# create temporary table for edit tests
self.execSQLCommand('DROP TABLE "QGIS"."EDIT_DATA"', ignore_errors=True)
@@ -79,7 +78,6 @@ def getSource(self):
'test', 'oracle')
return vl

# disabled: WIP
def getEditableLayer(self):
return self.getSource()

0 comments on commit c3b6990

Please sign in to comment.
You can’t perform that action at this time.