Allow QgsVectorFileWriter to report approx progress

qgis · Feb 12, 2017 · c42f1ec · c42f1ec
1 parent 8182ec2
commit c42f1ec
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/core/qgsvectorfilewriter.cpp b/src/core/qgsvectorfilewriter.cpp
@@ -2424,6 +2424,9 @@ QgsVectorFileWriter::writeAsVectorFormat( QgsVectorLayer* layer,
   writer->mFields = layer->fields();
 
   // write all features
+  long saved = 0;
+  long total = options.onlySelectedFeatures ? layer->selectedFeatureCount() : layer->featureCount();
+  int lastProgressReport = 0;
   while ( fit.nextFeature( fet ) )
   {
     if ( options.feedback && options.feedback->isCanceled() )
@@ -2432,6 +2435,18 @@ QgsVectorFileWriter::writeAsVectorFormat( QgsVectorLayer* layer,
       return Canceled;
     }
 
+    saved++;
+    if ( options.feedback )
+    {
+      //avoid spamming progress reports
+      int newProgress = ( 100.0 * saved ) / total;
+      if ( newProgress < 100 && newProgress != lastProgressReport )
+      {
+        lastProgressReport = newProgress;
+        options.feedback->setProgress( lastProgressReport );
+      }
+    }
+
     if ( shallTransform )
     {
       try

diff --git a/src/core/qgsvectorfilewritertask.cpp b/src/core/qgsvectorfilewritertask.cpp
@@ -44,6 +44,8 @@ bool QgsVectorFileWriterTask::run()
   if ( !mLayer )
     return false;
 
+  connect( mOptions.feedback, &QgsFeedback::progressChanged, this, &QgsVectorFileWriterTask::setProgress );
+
   mError = QgsVectorFileWriter::writeAsVectorFormat(
              mLayer, mDestFileName, mOptions, &mNewFilename, &mErrorMessage );
   return mError == QgsVectorFileWriter::NoError;