Add a test for rule based labeling without setting

qgis · Jul 2, 2018 · c48388b · c48388b
1 parent 0b066e5
commit c48388b
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/tests/src/python/test_qgssymbollayer_createsld.py b/tests/src/python/test_qgssymbollayer_createsld.py
@@ -32,7 +32,7 @@
     QgsFontMarkerSymbolLayer, QgsEllipseSymbolLayer, QgsSimpleLineSymbolLayer,
     QgsMarkerLineSymbolLayer, QgsMarkerSymbol, QgsSimpleFillSymbolLayer, QgsSVGFillSymbolLayer,
     QgsLinePatternFillSymbolLayer, QgsPointPatternFillSymbolLayer, QgsVectorLayer, QgsVectorLayerSimpleLabeling,
-    QgsTextBufferSettings, QgsPalLayerSettings, QgsTextBackgroundSettings)
+    QgsTextBufferSettings, QgsPalLayerSettings, QgsTextBackgroundSettings, QgsRuleBasedLabeling)
 from qgis.testing import start_app, unittest
 from utilities import unitTestDataPath
 
@@ -1053,6 +1053,13 @@ def testRuleBasedLabels(self):
         ltValue = gt.childNodes().item(1)
         self.assertEqual("1000000", gtValue.toElement().text())
 
+        # check that adding a rule without settings does not segfault
+        xml1 = dom.toString()
+        layer.labeling().rootRule().appendChild(QgsRuleBasedLabeling.Rule(None))
+        dom, root = self.layerToSld(layer)
+        xml2 = dom.toString()
+        self.assertEqual(xml1, xml2)
+
     def updateLinePlacementProperties(self, layer, linePlacement, distance, repeat, maxAngleInternal=25, maxAngleExternal=-25):
         settings = layer.labeling().settings()
         settings.placement = linePlacement