Legend: leave away empty groups (fix #12969)

mhugent · nyalldawson · commit c7834751ba5e · 2016-06-16T12:51:37.000+10:00
diff --git a/src/core/qgslegendrenderer.cpp b/src/core/qgslegendrenderer.cpp
@@ -161,6 +161,7 @@ QList<QgsLegendRenderer::Atom> QgsLegendRenderer::createAtomList( QgsLayerTreeGr
 
       // Group subitems
       QList<Atom> groupAtoms = createAtomList( nodeGroup, splitLayer );
+      bool hasSubItems = groupAtoms.size() > 0;
 
       if ( nodeLegendStyle( nodeGroup ) != QgsComposerLegendStyle::Hidden )
       {
@@ -188,7 +189,12 @@ QList<QgsLegendRenderer::Atom> QgsLegendRenderer::createAtomList( QgsLayerTreeGr
           groupAtoms.append( atom );
         }
       }
-      atoms.append( groupAtoms );
+
+      if ( hasSubItems ) //leave away groups without content
+      {
+        atoms.append( groupAtoms );
+      }
+
     }
     else if ( QgsLayerTree::isLayer( node ) )
     {

Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,7 @@ QList<QgsLegendRenderer::Atom> QgsLegendRenderer::createAtomList( QgsLayerTreeGr`
`161`	`161`
`162`	`162`	`// Group subitems`
`163`	`163`	`QList<Atom> groupAtoms = createAtomList( nodeGroup, splitLayer );`
	`164`	`+ bool hasSubItems = groupAtoms.size() > 0;`
`164`	`165`
`165`	`166`	`if ( nodeLegendStyle( nodeGroup ) != QgsComposerLegendStyle::Hidden )`
`166`	`167`	`{`
`@@ -188,7 +189,12 @@ QList<QgsLegendRenderer::Atom> QgsLegendRenderer::createAtomList( QgsLayerTreeGr`
`188`	`189`	`groupAtoms.append( atom );`
`189`	`190`	`}`
`190`	`191`	`}`
`191`		`- atoms.append( groupAtoms );`
	`192`	`+`
	`193`	`+ if ( hasSubItems ) //leave away groups without content`
	`194`	`+ {`
	`195`	`+ atoms.append( groupAtoms );`
	`196`	`+ }`
	`197`	`+`
`192`	`198`	`}`
`193`	`199`	`else if ( QgsLayerTree::isLayer( node ) )`
`194`	`200`	`{`