Skip to content

Commit c78bdae

Browse files
committed
[oracle] Some updates to Oracle provider test suite
Now the Oracle provider passes the data provider edit stress/ conformance tests without issue!
1 parent bbd335a commit c78bdae

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

tests/src/python/test_provider_oracle.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def execSQLCommand(self, sql, ignore_errors=False):
6464
query.finish()
6565

6666
# disabled: WIP
67-
def disabled_getSource(self):
67+
def getSource(self):
6868
# create temporary table for edit tests
6969
self.execSQLCommand('DROP TABLE "QGIS"."EDIT_DATA"', ignore_errors=True)
7070
self.execSQLCommand("""CREATE TABLE QGIS.EDIT_DATA ("pk" INTEGER GENERATED by default ON null as IDENTITY(START WITH 1 INCREMENT BY 1) PRIMARY KEY, "cnt" INTEGER, "name" VARCHAR2(100), "name2" VARCHAR2(100), "num_char" VARCHAR2(100), GEOM SDO_GEOMETRY)""")
@@ -80,7 +80,7 @@ def disabled_getSource(self):
8080
return vl
8181

8282
# disabled: WIP
83-
def disabled_getEditableLayer(self):
83+
def getEditableLayer(self):
8484
return self.getSource()
8585

8686
def enableCompiler(self):
@@ -147,6 +147,13 @@ def uncompiledFilters(self):
147147
])
148148
return filters
149149

150+
def testAddFeatureWrongGeomType(self):
151+
"""
152+
We override this test for Oracle provider, because Oracle DBs don't care
153+
about geometry type constraints
154+
"""
155+
pass
156+
150157
# HERE GO THE PROVIDER SPECIFIC TESTS
151158
def testDateTimeTypes(self):
152159
vl = QgsVectorLayer('%s table="QGIS"."DATE_TIMES" sql=' %

0 commit comments

Comments
 (0)