Skip to content

Commit

Permalink
Revert "Remove virtual method from class which shouldn't be subclassed"
Browse files Browse the repository at this point in the history
This reverts commit 858129d.

I remember now... that was added to avoid a totally nonsense and
otherwise unfixable crash in the sip bindings...
  • Loading branch information
nyalldawson committed Apr 24, 2017
1 parent 7b3859b commit cb68c98
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions python/core/qgsproperty.sip
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ class QgsProperty
};

QgsProperty();
virtual ~QgsProperty();

static QgsProperty fromExpression( const QString& expression, bool isActive = true );
static QgsProperty fromField( const QString& fieldName, bool isActive = true );
static QgsProperty fromValue( const QVariant& value, bool isActive = true );
Expand Down
2 changes: 2 additions & 0 deletions src/core/qgsproperty.h
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,8 @@ class CORE_EXPORT QgsProperty
*/
QgsProperty();

virtual ~QgsProperty() = default;

/**
* Returns a new ExpressionBasedProperty created from the specified expression.
*/
Expand Down

0 comments on commit cb68c98

Please sign in to comment.