-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix loss of attributes for OGR provider (followup 72c9830)
- Loading branch information
1 parent
1b6395e
commit cc13c57
Showing
1 changed file
with
9 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc13c57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jef-n Not sure how this escaped our testing, but this is a nasty one. Any chance of stopping 2.10 and including this in a 2.10.1 release? There's more discussion over at 72c9830
cc13c57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this affects also Linux? I use master on a regularly basis on Linux and I haven't seen this bug in the past days. Just noticed today on Windows/2.10.
cc13c57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson where's the backport?
Of course this must popup right after the release, again before the announcement and all packages being built. Although it's were just the LTR builds that were still running - but it's wasn't final-2_8_2 state anyway, but latest on the branch - ie. with your load of 2.10 backports and I just committed mine...
So there should probably be a 2.8.3 soon too.
Should we wait some more for feedback on 2.10? People probably won't try qgis-ltr-dev / debian-nightly-ltr / ubuntugis-nightly-ltr either. :(
cc13c57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there even was a ticket for it.
cc13c57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jef-n I don't think the original issue in that ticket is directly related - it refers to an issue in 2.8, and as far as I'm aware the offending commit wasn't backported to 2.8. But dash WAS reporting failures to us. It's just unfortunate that they got drowned in the noise of other failing OSX tests. I'm working on resolving that now...
cc13c57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson if that was actually intended. 2.8.2 was the default for new tickets. I removed the default and now it appears with Please select...
cc13c57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jef-n I've backported in 3738c91