There are no files selected for viewing
5 comments
on commit cc7e960
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, I forgot to add it to the commit. You are right. The force vector flag isn't necessary but the remaining ones are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson , thinking about this some more, I'm wondering whether we should have the drawSelection flag on. It'd behave like 2.x's save as image, and it can be useful when someone wants to do a "quick and dirty" visual highlight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. But not the editing markers. And antialiasing should respect the canvas setting for antialiasing too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson , we could consider removing non-antialiasing altogether for QGIS 3.0. Is it really relevant and/or useful to do non-antialiased rendering circa 2017?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that some people use it to export maps with a limited color palette, so i think the option should remain.
should these flags be applied to the save map as image export too?